-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OUDS] Docs: add 'Getting Started > JavaScript' page #2648
base: ouds/main
Are you sure you want to change the base?
[OUDS] Docs: add 'Getting Started > JavaScript' page #2648
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
32ea1ca
to
9278d41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the importmap, shouldn't it be @ouds/web
instead of ouds-web
? anyway it has no impact.
c8c9e31
to
30c9afa
Compare
d8d7bfe
to
cb82c4f
Compare
Yes, you're right, it's done like this for Popper. I've updated the CodePens and the PR with 94fc64c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
Warning
This PR stays valid but is on hold until we actually have our first official JavaScript components for OUDS Web
Related issues
Listed in #2589
Description
This PR adds the "Getting Started > Contribute" page based on:
Important
Everything that is described in this page must be tested!
To help you do the review, I've created some CodePens:
Types of change
Live previews