Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Docs: Add visually-hidden to side menu of the docs #2623

Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 16, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Resolves #2612 (comment)

Description

Add a <span class="visually-hidden"> to convey the information that the page isn't ready yet without even clicking on the link.

Motivation & Context

Better a11y.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is well displayed in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added accessibility docs Improvements or additions to documentation labels Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit e753772
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/669758ca7d3a9b00085a5a83
😎 Deploy Preview https://deploy-preview-2623--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit 3696c26 into ouds/main Jul 17, 2024
8 checks passed
@julien-deramond julien-deramond deleted the ouds/main-lmp-handle-visually-hidden-side-menu branch July 17, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants