chore(deps): bump tarteaucitronjs from 1.15.0 to 1.16.1 #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
added
v5
dependencies
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
louismaximepiton
approved these changes
Jan 30, 2024
julien-deramond
deleted the
main-jd-bump-tarteaucitronjs-deps-to-v1.16.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps tarteaucitronjs version from 1.15.0 to 1.16.1:
Tarteaucitronjs now checks the current path whether the file is minified or not to deduce if the other files are minified too.
In our case, it causes an issue either in production or development mode because the minified version of tarteaucitronjs content can be embedded in
docs.js(which is not minified). It creates an incompatibility withtarteaucitron.service.js(minified or not). Based on these discrepancies observed either in production or development mode, we decided to simplify our approach.docs.jsis now minified in all cases!Moreover, we discovered that we embedded tarteaucitronjs in
docs.min.jsand we also integrated it in a<script>HTML tag. Again, to simplify, we only kept the version embedded intodocs.min.js.Types of change
Live previews