-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar: Handle in a proper way our dropdowns inside documentation navbar #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
v5
docs
Improvements or additions to documentation
fix
css
labels
Dec 20, 2023
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-lmp-navbar-fix-mobile-scroll
branch
from
December 26, 2023 08:26
d78bcd9
to
cf96e9d
Compare
louismaximepiton
changed the base branch from
main
to
main-lmp-theme-switcher-control
December 26, 2023 09:58
louismaximepiton
changed the base branch from
main-lmp-theme-switcher-control
to
main
December 26, 2023 10:03
louismaximepiton
force-pushed
the
main-lmp-navbar-fix-mobile-scroll
branch
from
December 26, 2023 11:11
1b6bd46
to
d90e3b7
Compare
julien-deramond
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can't do better right now.
Let's create an issue too regarding the fact that we had to add a .bd-header
instead of using .bd-navbar
as it is done on the Bootstrap side.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an issue when we wanted to explore an overcharged navbar with some dropdowns for example.
We implement a little different behavior than Bootstrap since we have much complex navbars.
Reorganize docs navbar to have something more branded navbar (more spacing).
Live previews