Dark mode: drop bottom-right theme selector for Download page and Form examples #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
925329e to
094ee64
Compare
julien-deramond
force-pushed
the
main-jd-drop-theme-selector-in-2-example-pages
branch
from
73e6a2f to
6efe26f
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
2fe8f46 to
77711bd
Compare
julien-deramond
force-pushed
the
main-jd-drop-theme-selector-in-2-example-pages
branch
from
6efe26f to
3da2afd
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
77711bd to
555c600
Compare
julien-deramond
force-pushed
the
main-jd-drop-theme-selector-in-2-example-pages
branch
2 times, most recently
from
d6e8471 to
106d869
Compare
julien-deramond
changed the base branch from
main-jd-dark-mode
to
main-lmp-theme-switcher-control
louismaximepiton
requested changes
Dec 27, 2023
Base automatically changed from
main-lmp-theme-switcher-control
to
main-jd-dark-mode
December 27, 2023 10:07
julien-deramond
force-pushed
the
main-jd-drop-theme-selector-in-2-example-pages
branch
from
9995202 to
85c826e
Compare
julien-deramond
force-pushed
the
main-jd-drop-theme-selector-in-2-example-pages
branch
from
85c826e to
14de9ca
Compare
louismaximepiton
approved these changes
Dec 27, 2023
julien-deramond
deleted the
main-jd-drop-theme-selector-in-2-example-pages
branch
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
…m examples (#2427) Co-authored-by: louismaxime.piton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR drops the bottom-right theme selector for the download app and forms page examples. These examples now contain a theme selector at the right place in the header.
Motivation
This is done this way to avoid users misunderstanding where to put the theme selector on a real Orange page.
Live previews