-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: Utilities (bg, border, color) #2362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
color mode
Temporary label to highlight color mode issues
label
Nov 8, 2023
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 8, 2023 13:54
6b93b32
to
af61298
Compare
louismaximepiton
force-pushed
the
main-lmp-utitlities-dark
branch
2 times, most recently
from
November 8, 2023 15:11
457723b
to
13f2e1d
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 10, 2023 05:44
af61298
to
85428a8
Compare
julien-deramond
force-pushed
the
main-lmp-utitlities-dark
branch
from
November 10, 2023 05:46
79aaac7
to
a3c8841
Compare
louismaximepiton
force-pushed
the
main-lmp-utitlities-dark
branch
4 times, most recently
from
November 10, 2023 14:06
60e6248
to
9c556cd
Compare
This was referenced Nov 10, 2023
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 13, 2023 06:08
85428a8
to
5326d71
Compare
julien-deramond
force-pushed
the
main-lmp-utitlities-dark
branch
from
November 13, 2023 06:10
9c556cd
to
d4cd46f
Compare
julien-deramond
force-pushed
the
main-lmp-utitlities-dark
branch
from
November 13, 2023 07:43
d4cd46f
to
2493e52
Compare
julien-deramond
suggested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some lil changes to check together and let's merge
julien-deramond
approved these changes
Nov 13, 2023
Merged
julien-deramond
added a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 8, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Julien Déramond <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilities in dark mode, by using existing Sass vars :
$primary
has been changed, might have some impacts on user side$accessible-orange
should change its namedata-bs-theme="inverted"
for.*bg-secondary
(toasts color schemes).--bs-primary
instead of--bs-link-hover-color
--bs-secondary
instead of--bs-body-color
or--bs-highlight-bg
.bg-supporting-orange
as asked during the weekly synch meeting and.border-tertiary
that might be useful. This commit could be split and done aferwards..text-bg-*
would need some new variables to work correctly something like--bs-on-*
..text-body-tertiary
is somehow transparent in light mode..bg-primary|success|etc.
and.bg-supporting-*
(how to use them)$bd-primary
orange colors and all colors fromsite/assets/scss/_variables.scss
must be modified/refactored<span class="border border-tertiary"></span>
?values: map-merge($utilities-border-colors, ("tertiary": var(--#{$prefix}border-color-translucent)))
in _utilities.scss?$brand-orange
(remove) ->$supporting-orange
(create) and$accessible-orange
(remove) ->$primary
Links