Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Utilities (bg, border, color) #2362

Merged
merged 11 commits into from
Nov 13, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Nov 8, 2023

Description

Utilities in dark mode, by using existing Sass vars :

⚠️ $primary has been changed, might have some impacts on user side
⚠️ $accessible-orange should change its name
⚠️ Need to have data-bs-theme="inverted" for .*bg-secondary (toasts color schemes).
⚠️ We could use --bs-primary instead of --bs-link-hover-color
⚠️ We could use --bs-secondary instead of --bs-body-color or --bs-highlight-bg
⚠️ Last commit bring two more utilities .bg-supporting-orange as asked during the weekly synch meeting and .border-tertiary that might be useful. This commit could be split and done aferwards.
⚠️ .text-bg-* would need some new variables to work correctly something like --bs-on-*.
⚠️ .text-body-tertiary is somehow transparent in light mode.
⚠️ Rework docs/5.3/utilities/colors/#oranges-colors to explain it clearly
⚠️ Explain in the documentation the rules between .bg-primary|success|etc. and .bg-supporting-* (how to use them)
⚠️ Checkboxes and radios orange colors?? Shouldn't change.
⚠️ $bd-primary orange colors and all colors from site/assets/scss/_variables.scss must be modified/refactored

⚠️ Proposal not integrated in this PR

<div class="p-3 mb-2 fw-bold bg-primary"><span class="text-body" data-bs-theme="light">.bg-primary</span></div>
<div class="p-3 mb-2 fw-bold bg-secondary"><span class="text-body" data-bs-theme="inverted">.bg-secondary</span></div>
<div class="p-3 mb-2 fw-bold bg-success"><span class="text-body" data-bs-theme="inverted">.bg-success</span></div>
<div class="p-3 mb-2 fw-bold bg-danger"><span class="text-body" data-bs-theme="inverted">.bg-danger</span></div>
<div class="p-3 mb-2 fw-bold bg-warning"><span class="text-body" data-bs-theme="light">.bg-warning</span></div>
<div class="p-3 mb-2 fw-bold bg-info"><span class="text-body" data-bs-theme="inverted">.bg-info</span></div>
<div class="p-3 mb-2 fw-bold bg-supporting-green"><span class="text-body" data-bs-theme="light">.bg-supporting-green</span></div>
<div class="p-3 mb-2 fw-bold bg-supporting-purple"><span class="text-body" data-bs-theme="light">.bg-supporting-purple</span></div>
<div class="p-3 mb-2 fw-bold bg-supporting-yellow"><span class="text-body" data-bs-theme="light">.bg-supporting-yellow</span></div>
<div class="p-3 mb-2 fw-bold bg-supporting-blue"><span class="text-body" data-bs-theme="light">.bg-supporting-blue</span></div>
<div class="p-3 mb-2 fw-bold bg-supporting-pink"><span class="text-body" data-bs-theme="light">.bg-supporting-pink</span></div>
<div class="p-3 mb-2 fw-bold bg-supporting-orange"><span class="text-body" data-bs-theme="light">.bg-supporting-pink</span></div>
<div class="p-3 mb-2 fw-bold bg-light"><span class="text-body" data-bs-theme="light">.bg-light</span></div>
<div class="p-3 mb-2 fw-bold bg-dark"><span class="text-body" data-bs-theme="dark">.bg-dark</span></div>
<div class="p-3 mb-2 fw-bold bg-body-secondary"><span class="text-body" data-bs-theme="body">.bg-body-secondary</span></div>
<div class="p-3 mb-2 fw-bold bg-body-tertiary"><span class="text-body" data-bs-theme="body">.bg-body-tertiary</span></div>
<div class="p-3 mb-2 fw-bold bg-body"><span class="text-body" data-bs-theme="body">.bg-body</span></div>
<div class="p-3 mb-2 fw-bold bg-black"><span class="text-body" data-bs-theme="dark">.bg-black</span></div>
<div class="p-3 mb-2 fw-bold bg-white"><span class="text-body" data-bs-theme="light">.bg-white</span></div>
<div class="p-3 mb-2 fw-bold bg-transparent"><span class="text-body" data-bs-theme="body">.bg-transparent</span></div>

⚠️ Add <span class="border border-tertiary"></span>?

  • values: map-merge($utilities-border-colors, ("tertiary": var(--#{$prefix}border-color-translucent))) in _utilities.scss?

⚠️ $brand-orange (remove) -> $supporting-orange (create) and $accessible-orange (remove) -> $primary

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Nov 8, 2023
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit efe2708
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6552273a289b680008fd4d7d
😎 Deploy Preview https://deploy-preview-2362--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton force-pushed the main-lmp-utitlities-dark branch 2 times, most recently from 457723b to 13f2e1d Compare November 8, 2023 15:11
@julien-deramond julien-deramond force-pushed the main-lmp-utitlities-dark branch from 79aaac7 to a3c8841 Compare November 10, 2023 05:46
@louismaximepiton louismaximepiton marked this pull request as ready for review November 10, 2023 09:20
@louismaximepiton louismaximepiton force-pushed the main-lmp-utitlities-dark branch 4 times, most recently from 60e6248 to 9c556cd Compare November 10, 2023 14:06
@julien-deramond julien-deramond force-pushed the main-lmp-utitlities-dark branch from 9c556cd to d4cd46f Compare November 13, 2023 06:10
@julien-deramond julien-deramond force-pushed the main-lmp-utitlities-dark branch from d4cd46f to 2493e52 Compare November 13, 2023 07:43
scss/_root.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lil changes to check together and let's merge

@julien-deramond julien-deramond self-requested a review November 13, 2023 13:42
@julien-deramond julien-deramond merged commit bcdc5e9 into main-jd-dark-mode Nov 13, 2023
15 checks passed
@julien-deramond julien-deramond deleted the main-lmp-utitlities-dark branch November 13, 2023 13:53
@julien-deramond julien-deramond mentioned this pull request Nov 13, 2023
julien-deramond added a commit that referenced this pull request Nov 15, 2023
julien-deramond added a commit that referenced this pull request Nov 27, 2023
julien-deramond added a commit that referenced this pull request Nov 27, 2023
julien-deramond added a commit that referenced this pull request Nov 27, 2023
julien-deramond added a commit that referenced this pull request Nov 29, 2023
julien-deramond added a commit that referenced this pull request Nov 30, 2023
julien-deramond added a commit that referenced this pull request Dec 1, 2023
julien-deramond added a commit that referenced this pull request Dec 4, 2023
julien-deramond added a commit that referenced this pull request Dec 8, 2023
julien-deramond added a commit that referenced this pull request Dec 15, 2023
julien-deramond added a commit that referenced this pull request Dec 18, 2023
julien-deramond added a commit that referenced this pull request Dec 21, 2023
julien-deramond added a commit that referenced this pull request Dec 26, 2023
julien-deramond added a commit that referenced this pull request Dec 27, 2023
julien-deramond added a commit that referenced this pull request Jan 2, 2024
@julien-deramond julien-deramond mentioned this pull request Jan 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants