Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Title bars #2350

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Dark mode: Title bars #2350

merged 4 commits into from
Nov 8, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 31, 2023 •
edited by boosted-bot
Loading

Description

Title bars in dark mode, by using existing and new Sass vars :

Sass var Previous value New value
$title-bar-bg - var(--#{$prefix}body-bg)
$title-bar-color - var(--#{$prefix}body-color)
$title-bar-border-color $gray-500 var(--#{$prefix}border-color-translucent)

⚠️ Deprecated $title-bar-border-color-dark
⚠️ New CSS var that could be avoided by #2313: --bs-title-bar-bg & --bs-title-bar-color

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 31, 2023
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c176667
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/654b30ce72ee2d0009b5849c
😎 Deploy Preview https://deploy-preview-2350--boosted.netlify.app/docs/5.3/components/title-bars
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond force-pushed the main-lmp-title-bars-dark branch from c4fedfa to dd6dc27 Compare November 3, 2023 10:34
@julien-deramond julien-deramond force-pushed the main-lmp-title-bars-dark branch from dd6dc27 to 0edf9d4 Compare November 3, 2023 11:44
@julien-deramond julien-deramond force-pushed the main-jd-dark-mode branch 2 times, most recently from 35328ca to f0b8a1e Compare November 6, 2023 07:18
@julien-deramond julien-deramond force-pushed the main-lmp-title-bars-dark branch 2 times, most recently from 80c2854 to 9738f05 Compare November 7, 2023 09:01
@julien-deramond julien-deramond force-pushed the main-lmp-title-bars-dark branch from 7097bac to 0b9db27 Compare November 7, 2023 12:03
julien-deramond
julien-deramond approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not certain that it's better to use data-bs-theme rather than background and text color utilities; let's merge and think about it.

@julien-deramond julien-deramond merged commit 6b93b32 into main-jd-dark-mode Nov 8, 2023
15 checks passed
@julien-deramond julien-deramond deleted the main-lmp-title-bars-dark branch November 8, 2023 06:57
@julien-deramond julien-deramond mentioned this pull request Nov 8, 2023
Merged
julien-deramond added a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
af61298 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
85428a8 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
5326d71 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
3716eed 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
9b964fb 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
79340a3 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
afef5eb 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
d384f53 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
80d5d31 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
a65267b 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
be6fce8 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
05fd36b 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
a4a101f 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
384f357 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
5e6c5e8 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
93190a3 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
9ee31a9 
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Title bars (#2350)
d0a8676 
Co-authored-by: Julien Déramond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond