Chore: merge from ce11411 to f7426c0 #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
commented
Oct 24, 2023
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
commented
Oct 24, 2023
| @@ -192,7 +192,7 @@ An additional navbar (with text or icon items) can be added on the right of the | |||
| </svg> | |||
| <span class="visually-hidden">Basket</span> | |||
| <span class="position-relative align-self-start"> | |||
| <span class="badge bg-info rounded-pill position-absolute top-0 fs-6 text-white translate-middle"> | |||
| <span class="badge text-bg-info rounded-pill position-absolute top-0 fs-6 text-white translate-middle"> | |||
There was a problem hiding this comment.
There's no impact here but we will need to define in the dark mode implementation whether .text-bg-info should render the text color in white automatically or black. For now, .text-white is still needed.
louismaximepiton
requested changes
Oct 24, 2023
julien-deramond
changed the title
louismaximepiton
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twbs/bootstrap@d58e86e: we dont' have table head/foot in Boosted. We might need to reintroduce them in a separate PR.