Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Modal #2322

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Dark mode: Modal #2322

merged 1 commit into from
Oct 25, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 18, 2023 •
edited
Loading

Description

Modals in dark mode, by using existing Sass vars :

Sass var Previous value New value
$modal-content-color null var(--#{$prefix}body-color)

⚠️ Need a data-bs-theme="body" somehow ?

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 83c9c70
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6538ba26e5c39b00080a7322
😎 Deploy Preview https://deploy-preview-2322--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit d96d1a8 into main-jd-dark-mode Oct 25, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-modal-dark branch October 25, 2023 06:55
@julien-deramond julien-deramond mentioned this pull request Oct 25, 2023
Merged
julien-deramond pushed a commit that referenced this pull request Oct 26, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
2c4ddcb
julien-deramond pushed a commit that referenced this pull request Oct 31, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
a2a19f0
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
b13fcae
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
7e97b9f
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
0ea5b36
julien-deramond pushed a commit that referenced this pull request Nov 6, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
20af865
julien-deramond pushed a commit that referenced this pull request Nov 7, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
f8499c2
julien-deramond pushed a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
5b9926a
julien-deramond pushed a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
a88e70b
julien-deramond pushed a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
8bdc836
julien-deramond pushed a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
7ff249e
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
3d55490
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
01a1d27
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
285115b
julien-deramond pushed a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
0febb24
julien-deramond pushed a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
91163dd
julien-deramond pushed a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
75a4ae1
julien-deramond pushed a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
2214472
julien-deramond pushed a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
e555e7c
julien-deramond pushed a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
39ea342
julien-deramond pushed a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
15014fa
julien-deramond pushed a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
5c9201b
julien-deramond pushed a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
2c6686f
julien-deramond pushed a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
e1ecbdf
julien-deramond pushed a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: modal (#2322)
877fa75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond