Dark mode: Cards #2318
Merged
Dark mode: Cards #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
8ae7abe to
670f453
Compare
louismaximepiton
force-pushed
the
main-lmp-card-dark
branch
from
35e8b91 to
a4fee7c
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
bbf1afd to
fc169fa
Compare
julien-deramond
force-pushed
the
main-lmp-card-dark
branch
from
a4fee7c to
8edb5da
Compare
|
IMO "Featured" area should stay black in dark mode. It seems off, especially in https://deploy-preview-2318--boosted.netlify.app/docs/5.3/components/card/#background-and-color and https://deploy-preview-2318--boosted.netlify.app/docs/5.3/components/card/#border. I'd say we aren't supposed to have white bg color in dark mode (too bright). Let's ask the designers.
|
|
In the dark mode page cards look like this: However, in the cards page: Cards page should be updated to use the darker image |
|
https://deploy-preview-2318--boosted.netlify.app/docs/5.3/components/card/#navigation is broken in dark mode |
|
Cards example page should be updated too. Based on what we can see in the PR, maybe we can drop temporarily the second part of this page since folks should rather use contextual dark mode instead of these dark variants isn't it? |
Merged
julien-deramond
added a commit
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 6, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 10, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 8, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Julien Déramond <[email protected]>
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Julien Déramond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cards in dark mode, by using existing Sass vars :
$card-cap-bg$blackvar(--#{$prefix}highlight-bg)$btn-close-active-border-color$whitevar(--#{$prefix}highlight-bg)$btn-close-disabled-color$gray-700var(--#{$prefix}placeholder-color)Links