Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Carousel #2316

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Dark mode: Carousel #2316

merged 1 commit into from
Oct 27, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 17, 2023 •
edited
Loading

Description

⚠️ Modified $headings-color from inherit to $black

Carousel in dark mode, by using existing and new Sass vars :

Sass var Previous value New value
$headings-color inherit $black
$carousel-control-icon-color - $black
$carousel-caption-color $black var(--#{$prefix}body-color)
$carousel-caption-bg - var(--#{$prefix}body-bg)

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit de1ed36
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/653b683c79e0e500085ae790
😎 Deploy Preview https://deploy-preview-2316--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton force-pushed the main-lmp-carousel-dark branch 2 times, most recently from 0fe0903 to 5b49197 Compare October 18, 2023 08:15
@julien-deramond julien-deramond merged commit 40e40c7 into main-jd-dark-mode Oct 27, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-carousel-dark branch October 27, 2023 07:38
@julien-deramond julien-deramond mentioned this pull request Oct 27, 2023
Merged
julien-deramond pushed a commit that referenced this pull request Oct 31, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
12cac50
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
545cad8
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
929a355
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
5586f05
julien-deramond pushed a commit that referenced this pull request Nov 6, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
08926e8
julien-deramond pushed a commit that referenced this pull request Nov 7, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
6bd67c7
julien-deramond pushed a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
a9f2190
julien-deramond pushed a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
f696b56
julien-deramond pushed a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
3ab25c2
julien-deramond pushed a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
a278179
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
1e28249
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
3f21c72
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
4a87d8a
julien-deramond pushed a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
609f1a8
julien-deramond pushed a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
a9e9aad
julien-deramond pushed a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
ebea6f9
julien-deramond pushed a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
a8d835e
julien-deramond pushed a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
6590b9f
julien-deramond pushed a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
3788109
julien-deramond pushed a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
f2348f0
julien-deramond pushed a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
f26e83d
julien-deramond pushed a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
21bb75b
julien-deramond pushed a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
c68f34f
julien-deramond pushed a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Carousel (#2316)
55b3357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond