Dark Mode: Storybook addon #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode-storybook
branch
from
2da1316 to
cdd4828
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new dev dependency named
@storybook/addon-themeswhich allows the addition of a theme switcher within the Storybook interface (see https://storybook.js.org/blog/introducing-theme-switcher-addon/).This is not directly useful for Boosted team, but could be through ZeroHeight one day.
However, it allows us to be sure that https://github.com/Orange-OpenSource/ods-storybook-theme is working correctly with Boosted components, and this, can be useful for the projects when they develop their components in isolation.
Technically it handles a switch with our
data-bs-themeattribute.Be careful, the other button in the toolbar handles the dark mode of the SB interface (so only the background behind the stories right now).
Live preview