Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Form validation #2302

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 11, 2023

Description

Form validation in dark mode, by using existing and new Sass vars :

Sass var Previous value New value
$success-icon-dark - url(...)
$danger-icon-dark - url(...)
$form-valid-color-dark $green-300 var(--#{$prefix}succes-text-emphasis)
$form-valid-border-color-dark $green-300 var(--#{$prefix}success)
$form-invalid-color-dark $red-300 var(--#{$prefix}danger-text-emphasis)
$form-invalid-border-color-dark $red-300 var(--#{$prefix}danger)
$form-feedback-color - var(--#{$prefix}body-color)

⚠️ New values for CSS vars:

CSS var Light mode value Dark mode value
--bs-success-icon escape-svg($success-icon) escape-svg($success-icon-dark)
--bs-danger-icon escape-svg($danger-icon) escape-svg($danger-icon-dark)

⚠️ --bs-danger-icon could not change if we use mask for .invalid-feedback. I prefer unifying the both and since mask isn't possible for .is-valid, I let this as-is.

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 75d57a5
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/653a5b30e92a9000082d6923
😎 Deploy Preview https://deploy-preview-2302--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as draft October 11, 2023 14:45
@louismaximepiton louismaximepiton force-pushed the main-lmp-form-validation-dark branch from 09c7cbc to f8278c1 Compare October 11, 2023 15:06
@louismaximepiton louismaximepiton force-pushed the main-lmp-form-validation-dark branch 2 times, most recently from 3c6dc43 to 01efa19 Compare October 25, 2023 09:17
@louismaximepiton louismaximepiton marked this pull request as ready for review October 25, 2023 09:17
scss/_root.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond force-pushed the main-lmp-form-validation-dark branch from 707f8c3 to 75d57a5 Compare October 26, 2023 12:27
@julien-deramond julien-deramond self-requested a review October 27, 2023 06:18
@julien-deramond julien-deramond merged commit 74dcca2 into main-jd-dark-mode Oct 27, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-form-validation-dark branch October 27, 2023 06:18
@julien-deramond julien-deramond mentioned this pull request Oct 27, 2023
julien-deramond pushed a commit that referenced this pull request Oct 31, 2023
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
julien-deramond pushed a commit that referenced this pull request Nov 6, 2023
julien-deramond pushed a commit that referenced this pull request Nov 7, 2023
julien-deramond pushed a commit that referenced this pull request Nov 8, 2023
julien-deramond pushed a commit that referenced this pull request Nov 10, 2023
julien-deramond pushed a commit that referenced this pull request Nov 13, 2023
julien-deramond pushed a commit that referenced this pull request Nov 15, 2023
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
julien-deramond pushed a commit that referenced this pull request Nov 29, 2023
julien-deramond pushed a commit that referenced this pull request Nov 30, 2023
julien-deramond pushed a commit that referenced this pull request Dec 1, 2023
julien-deramond pushed a commit that referenced this pull request Dec 4, 2023
julien-deramond pushed a commit that referenced this pull request Dec 8, 2023
julien-deramond pushed a commit that referenced this pull request Dec 15, 2023
julien-deramond pushed a commit that referenced this pull request Dec 18, 2023
julien-deramond pushed a commit that referenced this pull request Dec 21, 2023
julien-deramond pushed a commit that referenced this pull request Dec 26, 2023
julien-deramond pushed a commit that referenced this pull request Dec 27, 2023
julien-deramond pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants