-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: Form validation #2302
Merged
julien-deramond
merged 1 commit into
main-jd-dark-mode
from
main-lmp-form-validation-dark
Oct 27, 2023
Merged
Dark mode: Form validation #2302
julien-deramond
merged 1 commit into
main-jd-dark-mode
from
main-lmp-form-validation-dark
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
color mode
Temporary label to highlight color mode issues
label
Oct 11, 2023
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
force-pushed
the
main-lmp-form-validation-dark
branch
from
October 11, 2023 15:06
09c7cbc
to
f8278c1
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
October 25, 2023 06:01
8ae7abe
to
670f453
Compare
louismaximepiton
force-pushed
the
main-lmp-form-validation-dark
branch
2 times, most recently
from
October 25, 2023 09:17
3c6dc43
to
01efa19
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
October 26, 2023 12:23
bbf1afd
to
fc169fa
Compare
julien-deramond
force-pushed
the
main-lmp-form-validation-dark
branch
from
October 26, 2023 12:27
707f8c3
to
75d57a5
Compare
julien-deramond
approved these changes
Oct 27, 2023
Merged
julien-deramond
pushed a commit
that referenced
this pull request
Oct 31, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 3, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 3, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 3, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 6, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 7, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 8, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 10, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 13, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 15, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 27, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 27, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 27, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 29, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Nov 30, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 1, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 4, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 8, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 15, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 18, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 21, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 26, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 27, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Form validation in dark mode, by using existing and new Sass vars :
$success-icon-dark
url(...)
$danger-icon-dark
url(...)
$form-valid-color-dark
$green-300
var(--#{$prefix}succes-text-emphasis)
$form-valid-border-color-dark
$green-300
var(--#{$prefix}success)
$form-invalid-color-dark
$red-300
var(--#{$prefix}danger-text-emphasis)
$form-invalid-border-color-dark
$red-300
var(--#{$prefix}danger)
$form-feedback-color
var(--#{$prefix}body-color)
--bs-success-icon
escape-svg($success-icon)
escape-svg($success-icon-dark)
--bs-danger-icon
escape-svg($danger-icon)
escape-svg($danger-icon-dark)
--bs-danger-icon
could not change if we usemask
for.invalid-feedback
. I prefer unifying the both and sincemask
isn't possible for.is-valid
, I let this as-is.Links