Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Quantity selector #2287

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Dark mode: Quantity selector #2287

merged 2 commits into from
Oct 25, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 6, 2023 •
edited
Loading

Description

Form checks in dark mode, by using new Sass vars :

Sass var Previous value New value
$quantity-selector-disabled-color - var(--#{$prefix}disabled-color)
$quantity-selector-disabled-bg - var(--#{$prefix}body-bg)
$quantity-selector-button-bg - var(--#{$prefix}body-bg)
$quantity-selector-button-border - var(--#{$prefix}border-width) solid var(--#{$prefix}border-color-translucent)

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 6, 2023
@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 00e963f
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6538caea0b86e400083a8114
😎 Deploy Preview https://deploy-preview-2287--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond

This comment was marked as resolved.

Sign in to view
@louismaximepiton louismaximepiton marked this pull request as ready for review October 10, 2023 08:45
@louismaximepiton louismaximepiton force-pushed the main-lmp-qs-dark branch 2 times, most recently from e54b0e7 to 80c0cbc Compare October 25, 2023 07:09
@julien-deramond julien-deramond merged commit 4a2f4c0 into main-jd-dark-mode Oct 25, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-qs-dark branch October 25, 2023 08:47
@julien-deramond julien-deramond mentioned this pull request Oct 25, 2023
Merged
julien-deramond pushed a commit that referenced this pull request Oct 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
937d7a2
julien-deramond pushed a commit that referenced this pull request Oct 31, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
a437d1d
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
c5fe95a
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
412c2a4
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
4753107
julien-deramond pushed a commit that referenced this pull request Nov 6, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
f79a06c
julien-deramond pushed a commit that referenced this pull request Nov 7, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
e4f2455
julien-deramond pushed a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
bf27207
julien-deramond pushed a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
7387b02
julien-deramond pushed a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
5dd9209
julien-deramond pushed a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
74cfb2b
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
b4f1bd6
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
2d6b719
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
4232555
julien-deramond pushed a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
5834908
julien-deramond pushed a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
f4af53b
julien-deramond pushed a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
ab17bed
julien-deramond pushed a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
1c90f43
julien-deramond pushed a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
ab465b1
julien-deramond pushed a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
14f0340
julien-deramond pushed a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
c5f4736
julien-deramond pushed a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
3a8659b
julien-deramond pushed a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
ceb009f
julien-deramond pushed a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
af002cf
julien-deramond pushed a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Quantity selector (#2287)
942a3cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond