Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Form select #2286

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 6, 2023

Description

Form checks in dark mode, by using existing and new Sass vars :

Indicates the color value of the icon:

Sass var Previous value New value
$form-select-disabled-color $gray-700 $input-disabled-color
$form-select-indicator - -
$form-select-disabled-indicator $form-select-disabled-color #666666
$form-select-indicator-dark - #ffffff
$form-select-disabled-indicator-dark - #999999

⚠️ New CSS vars:

Indicates the color value of the icon:

CSS var Light mode value Dark mode value
--bs-select-indicator #000000 #ffffff
--bs-select-disabled-indicator #666666 #999999

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 6, 2023
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 2d0a572
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6538c75f64c9fc00080ade77
😎 Deploy Preview https://deploy-preview-2286--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton force-pushed the main-lmp-select-dark branch 2 times, most recently from 3eb22ac to 4d5485d Compare October 25, 2023 06:43
scss/_variables-dark.scss Outdated Show resolved Hide resolved
scss/_variables.scss Outdated Show resolved Hide resolved
scss/forms/_form-select.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond self-requested a review October 25, 2023 07:44
@julien-deramond julien-deramond merged commit b5f692e into main-jd-dark-mode Oct 25, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-select-dark branch October 25, 2023 07:45
@julien-deramond julien-deramond mentioned this pull request Oct 25, 2023
julien-deramond pushed a commit that referenced this pull request Oct 26, 2023
julien-deramond pushed a commit that referenced this pull request Oct 31, 2023
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
julien-deramond pushed a commit that referenced this pull request Nov 6, 2023
julien-deramond pushed a commit that referenced this pull request Nov 7, 2023
julien-deramond pushed a commit that referenced this pull request Nov 8, 2023
julien-deramond pushed a commit that referenced this pull request Nov 10, 2023
julien-deramond pushed a commit that referenced this pull request Nov 13, 2023
julien-deramond pushed a commit that referenced this pull request Nov 15, 2023
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
julien-deramond pushed a commit that referenced this pull request Nov 29, 2023
julien-deramond pushed a commit that referenced this pull request Nov 30, 2023
julien-deramond pushed a commit that referenced this pull request Dec 1, 2023
julien-deramond pushed a commit that referenced this pull request Dec 4, 2023
julien-deramond pushed a commit that referenced this pull request Dec 8, 2023
julien-deramond pushed a commit that referenced this pull request Dec 15, 2023
julien-deramond pushed a commit that referenced this pull request Dec 18, 2023
julien-deramond pushed a commit that referenced this pull request Dec 21, 2023
julien-deramond pushed a commit that referenced this pull request Dec 26, 2023
julien-deramond pushed a commit that referenced this pull request Dec 27, 2023
julien-deramond pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants