-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: Stepped process #2273
Dark mode: Stepped process #2273
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments and we're good to go for this first version of semi-complex component
bb078d6
to
36cb3f0
Compare
…k-mode-stepped-process # Conflicts: # scss/_variables.scss
…m Franco) and intermediary sass variable
…d bs-link-color in dark mode test page
Co-authored-by: Louis-Maxime Piton <[email protected]>
Co-authored-by: Louis-Maxime Piton <[email protected]>
Co-authored-by: Louis-Maxime Piton <[email protected]>
…k-mode-stepped-process
…k-mode-stepped-process
…component bg (specially arrows between steps)
# Conflicts: # site/content/docs/5.3/components/navbar.md # site/layouts/shortcodes/callout-deprecated-dark-variants.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Stepped process in dark mode, by using existing css vars :
$step-item-bg
:--bs-highlight-bg
- to switch from black to white ---bs-highlight-bg
to be noted)$step-item-next-bg
:--bs-border-color-translucent
- to switch from#ccc
to#666
---bs-border-color-translucent
to be noted)$step-item-drop-shadow
: using--bs-stepped-process-bg
which is equal to--bs-body-bg
- to switch from white to black$step-link-color
:--bs-link-color
- to switch from black to white$step-link-next-color
:--bs-link-color
- to switch from black to white#ddd
to#ccc
by this PR--bs-stepped-process-bg
equals to--bs-body-bg
but ca,n be changed by users--bs-stepped-process-bg
Links