Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode: Update syntax file dark #2258

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Sep 19, 2023

Description

Introduce new color palette for dark mode.

Motivation & Context

New color palette for dark mode closer to Bootstrap:
screenshot-localhost_9001-2023 09 19-17_25_04

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • (na) My change respects the design guidelines defined in Orange Design System
  • (na) My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • (na) I have added JavaScript unit tests to cover my changes
  • (na) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (na) My new component is well displayed in Storybook
  • (na) My new component is compatible with RTL
  • (na) Manually run BrowserStack tests
  • (na) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@MewenLeHo MewenLeHo added v5 brand feature color mode Temporary label to highlight color mode issues labels Sep 19, 2023
@MewenLeHo MewenLeHo self-assigned this Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1654525
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/650aabf91d2b6b0008220939
😎 Deploy Preview https://deploy-preview-2258--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond changed the base branch from main to main-jd-dark-mode September 19, 2023 19:39
@julien-deramond julien-deramond changed the title Update syntax file dark Dark Mode: Update syntax file dark Sep 20, 2023
@julien-deramond julien-deramond marked this pull request as ready for review September 22, 2023 07:22
@julien-deramond julien-deramond self-requested a review September 22, 2023 07:22
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a first version. The rendering is already better.
But let's continue to work on it for improvements.

@julien-deramond julien-deramond merged commit ee11266 into main-jd-dark-mode Sep 22, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-mlh-update-syntax-file-dark branch September 22, 2023 07:23
@julien-deramond julien-deramond mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand color mode Temporary label to highlight color mode issues feature v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants