Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deactivate dark mode for release v5.3.2 #2245

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Sep 18, 2023

It's that time again... deactivating dark mode for the release v5.3.2. This PR basically reverts https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/2158/files like it was done in #2170 for the release of v5.3.1.

⚠️ Please double-check that it is still working and that no other content included in this v5.3.2 needs some kind of deactivation.

Live preview

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation color mode Temporary label to highlight color mode issues labels Sep 18, 2023
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c1f050b
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6507f9c2bac7fb0008e198b7
😎 Deploy Preview https://deploy-preview-2245--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as ready for review September 18, 2023 06:36
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still an issue with download app example page CSS using this color mode.
Otherwise looks good to me!

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@julien-deramond julien-deramond merged commit 42ed176 into main Sep 18, 2023
@julien-deramond julien-deramond deleted the main-jd-deactivate-dark-mode-v5.3.2 branch September 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

2 participants