Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of toggle buttons borders #2239

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Sep 13, 2023

Related issues

Closes second part of #2163

Description

Coming from the work on font prototype where we now have multiple single toggle buttons not included in a .btn-group:

  <input type="checkbox" class="btn-check" id="btn-check" autocomplete="off">
  <label class="btn btn-primary mb-5" for="btn-check" onclick="toggleLines()">Toggle yellow lines display</label>

  <input type="checkbox" class="btn-check" id="btn-bg" autocomplete="off">
  <label class="btn btn-primary mb-5" for="btn-bg" onclick="toggleBackground()">Toggle red background display</label>

Simple solution was to make the selector a bit more specific.

Motivation & Context

Before the change:
screenshot-localhost_9001-2023 09 13-15_40_19

After the change:
screenshot-localhost_9001-2023 09 13-15_39_35

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • (na) My change follows accessibility good practices; I have at least run axe

Design

  • (na) My change respects the design guidelines defined in Orange Design System
  • (na) My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • (na) I have added JavaScript unit tests to cover my changes
  • (na) I have added SCSS unit tests to cover my changes

Documentation

  • (na) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (na) My change introduces changes to the migration guide
  • (na) My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • (na) Design review
  • (na) A11y review

After the merge

@MewenLeHo MewenLeHo self-assigned this Sep 13, 2023
@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 771e737
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/650a8253a23fc6000800f5e1
😎 Deploy Preview https://deploy-preview-2239--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MewenLeHo

This comment was marked as outdated.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's no need to have a migration note on this one.

@julien-deramond julien-deramond self-requested a review September 14, 2023 08:21
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a regression in the second example of https://deploy-preview-2239--boosted.netlify.app/docs/5.3/forms/checks-radios/#with-icon with the hover style:

2023-09-14 10 21 02

@louismaximepiton
Copy link
Member

Ah yes Good catch my bad on this.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any other breaking change. Can't find of another way to achieve this behavior.

@julien-deramond julien-deramond merged commit f7a377a into main Sep 20, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-mlh-fix-multiple-toggle-buttons branch September 20, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants