-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement of toggle buttons borders #2239
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's no need to have a migration note on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a regression in the second example of https://deploy-preview-2239--boosted.netlify.app/docs/5.3/forms/checks-radios/#with-icon with the hover style:
Ah yes Good catch my bad on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find any other breaking change. Can't find of another way to achieve this behavior.
Related issues
Closes second part of #2163
Description
Coming from the work on font prototype where we now have multiple single toggle buttons not included in a
.btn-group
:Simple solution was to make the selector a bit more specific.
Motivation & Context
Before the change:
After the change:
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge