Dark mode: Add $theme-colors-dark and $theme-colors-rgb-dark
#2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
v5
css
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
force-pushed
the
main-jd-dark-mode-tokens
branch
from
e8861eb to
b590177
Compare
|
TBH, not quite sure about the changes in the doc. maybe these should come later. Haven't changed the migration guide as weel for now since the variables might change. |
julien-deramond
changed the title
$theme-colors-dark and $theme-colors-rgb-dark
julien-deramond
force-pushed
the
main-jd-dark-mode-tokens
branch
3 times, most recently
from
21eba76 to
8fce157
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-tokens
branch
from
8fce157 to
08e197b
Compare
| // scss-docs-start theme-color-dark-variables | ||
| $primary-dark: $orange !default; | ||
| $secondary-dark: $black !default; | ||
| $success-dark: $functional-green-dark !default; |
There was a problem hiding this comment.
Don't we need to override $blue, $green, etc. + $colors or create *-dark versions of them?
In light mode we have:
$functional-green: #228722 !default;
$green: $functional-green !default;
$success: $green !default;In dark mode:
$functional-green-dark: #228722 !default;
$success: $functional-green-dark !default;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description of the main branch once merged:
Palette:
--bs-body-bg#ffffff#141414--bs-body-color#000000#eeeeee--bs-highlight-bg#000000#ffffff--bs-highlight-color#ffffff#000000--bs-secondary-bg#eeeeee#333333--bs-border-color-translucent#cccccc#666666--bs-secondary-color#666666#cccccc--bs-link-hover-color#f16e00#ff7900--bs-primary#ff7900#ff7900--bs-success#228722#32c832--bs-info#4170d8#527edb--bs-warning#ffcc00#ffcc00--bs-danger#cd3c14#d53f15If there's a new color that doesn't fit well in this table and none exist in actual, introduce a new one otherwise, update this description.
Tasks
theme-colors-dark-mapin the documentation (andtheme-colors-rgb-dark?) wheretheme-colors-mapis displayed Should be fine$theme-colors-darkin Boosted only (doesn't exist in Bootstrap) Should be finedocs/5.3/utilities/background/, it shows that we need to add a new text utility: white in light mode, black in dark mode.bg-primaryneed to switch between oranges in light and dark mode?bg-darkneed to be#141414? And in light mode which color? (seesite/data/theme-colors.ymlandcontrast_color)$body-secondary-color-darkimpacts in terms of usage Should be fine$body-secondary-bg-darkimpacts in terms of usage Should be fine$body-tertiary-color-darkimpacts in terms of usage Not quite sure, need further investigation$body-tertiary-bg-darkimpacts in terms of usage Should be fineTypes of change
Live previews