Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add disabled label to disabled file input #2222

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Sep 8, 2023

Description

In current documentation, the label for the disabled input file is missing a .is-disabled class.

screenshot-boosted orange com-2023 09 08-14_27_25

Whereas it should look like:
screenshot-deploy-preview-2222--boosted netlify app-2023 09 08-15_55_05

Motivation & Context

Make all disabled form element consistent across the documentation.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • [na] My change follows accessibility good practices; I have at least run axe

Design

  • [na] My change respects the design guidelines defined in Orange Design System
  • [na] My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • [na] I have added JavaScript unit tests to cover my changes
  • [na] I have added SCSS unit tests to cover my changes

Documentation

  • [na] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • [na] My change introduces changes to the migration guide
  • [na] My new component is well displayed in Storybook
  • [na] My new component is compatible with RTL
  • [na] Manually run BrowserStack tests
  • [na] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • [na] Design review
  • [na] A11y review

After the merge

@MewenLeHo MewenLeHo added v5 docs Improvements or additions to documentation fix labels Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 46f8060
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64fb269c4545120008ccebbb
😎 Deploy Preview https://deploy-preview-2222--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@julien-deramond julien-deramond self-requested a review September 11, 2023 10:56
@julien-deramond julien-deramond merged commit d249405 into main Sep 11, 2023
4 checks passed
@julien-deramond julien-deramond deleted the main-mlh-fix-missing-disabled-label branch September 11, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants