-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumb: Add the mobile version #2003
Open
louismaximepiton
wants to merge
15
commits into
main
Choose a base branch
from
main-lmp-breadcrumb-mobile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
870010b
Not optimized version
louismaximepiton 263b67a
Fix rtl + Add Boosted mods
louismaximepiton 1598a2e
.
louismaximepiton 910ede9
Migration guide
louismaximepiton bbf3bf7
fix(review)
louismaximepiton 51c8234
Merge branch 'main' into main-lmp-breadcrumb-mobile
louismaximepiton 0d49531
fix(design review)
louismaximepiton 7d515da
Merge branch 'main' into main-lmp-breadcrumb-mobile
julien-deramond 765c50b
Merge branch 'main' into main-lmp-breadcrumb-mobile
louismaximepiton 6afdeb1
Change migration guide
louismaximepiton 09313db
Merge branch 'main' into main-lmp-breadcrumb-mobile
julien-deramond e7694dc
fix CI
louismaximepiton 0d6ff77
Merge branch 'main' into main-lmp-breadcrumb-mobile
julien-deramond 7c5d444
Fix bundlewatch values
julien-deramond 2707be8
Merge branch 'main' into main-lmp-breadcrumb-mobile
louismaximepiton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of transforming it automatically, I'm wondering if we shouldn't provide a
$breadcrumb-divider-mobile
(not sure about the naming). Because if you choose "/" as a divider, in mobile mode you probably don't want it to be "".