-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tooltips and popover design according to UI Kit v5 #1803
Update tooltips and popover design according to UI Kit v5 #1803
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
9b2846a
to
92c4b03
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Might have found a solution by playing with |
…ttps://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap into main-mlh-update-tooltips-popover-design-new-ui-kit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @louismaximepiton I let you finalize your review as well and after that, let's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks fine to me, well done!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Decided in daily:
|
Related issues
Closes #1594
Description
Update tooltips and popovers design.
Motivation & Context
Compliance to UI Kit v5.
Types of change
Live previews
Tooltips: https://deploy-preview-1803--boosted.netlify.app/docs/5.3/components/tooltips/
Popovers: https://deploy-preview-1803--boosted.netlify.app/docs/5.3/components/popovers/#four-directions
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge