fix(review)

Orange-OpenSource · Dec 17, 2024 · c70d6f7 · c70d6f7
1 parent b6b2f0f
commit c70d6f7
Show file tree

Hide file tree

Showing 8 changed files with 41 additions and 41 deletions.
diff --git a/scss/_variables.scss b/scss/_variables.scss
diff --git a/site/assets/scss/_component-examples.scss b/site/assets/scss/_component-examples.scss
@@ -6,7 +6,7 @@
   display: flex; // OUDS mod
   flex-direction: column; // OUDS mod
   margin: 0 ($bd-gutter-x * -.5) 1rem;
-  border: solid var(--bs-color-border-emphasized); // OUDS mod: instead of `var(--bs-border-color)`
+  border: solid var(--bs-color-border-default); // OUDS mod: instead of `var(--bs-border-color)`
   border-width: 1px 0;
 
   @include media-breakpoint-up(md) {
@@ -23,7 +23,7 @@
   position: relative;
   padding: var(--bd-example-padding);
   margin: 0 ($bd-gutter-x * -.5) 1rem;
-  border: solid var(--bs-color-border-emphasized); // OUDS mod: instead of `var(--bs-border-color)`
+  border: solid var(--bs-color-border-default); // OUDS mod: instead of `var(--bs-border-color)`
   border-width: 1px 0;
   @include clearfix();
 
@@ -208,7 +208,7 @@
     font-weight: $font-weight-bold; // OUDS mod
     color: var(--bs-secondary-color);
     background-color: var(--bs-secondary-bg); // OUDS mod: instead of `var(--bs-tertiary-bg)`
-    border: var(--bs-border-width) solid var(--bs-color-border-emphasized); // OUDS mod: instead of `var(--bs-border-width) solid var(--bs-border-color)`
+    border: var(--bs-border-width) solid var(--bs-color-border-default); // OUDS mod: instead of `var(--bs-border-width) solid var(--bs-border-color)`
 
     > div {
       display: flex;
@@ -473,7 +473,7 @@
 // scss-docs-end sticker-fs-xl
 
 .border-subtle {
-  --bs-border-color: var(--bs-color-border-emphasized);
+  --bs-border-color: var(--bs-color-border-default);
 }
 
 .color-copy:hover > svg {

diff --git a/site/assets/scss/_content.scss b/site/assets/scss/_content.scss
@@ -55,7 +55,7 @@
     @include get-font-size("label-large");
     padding: 0 10px; // static even when zoomed
     line-height: 1.5;
-    border: var(--bs-border-color) dashed calc(var(--bs-border-width) * .5); // stylelint-disable-line function-disallowed-list
+    border: var(--bs-color-border-emphasized) dashed calc(var(--bs-border-width) * .5); // stylelint-disable-line function-disallowed-list
   }
   // End mod
 }
@@ -79,13 +79,13 @@
   }
 
   .border-top-thin {
-    border-top: 1px solid var(--bs-color-border-emphasized);
+    border-top: 1px solid var(--bs-color-border-default);
   }
 
   .border-color {
     width: 60px;
     height: 60px;
-    border: 1px solid var(--bs-color-border-emphasized);
+    border: 1px solid var(--bs-color-border-default);
   }
 
   td:last-child:not(:first-child) {

diff --git a/site/assets/scss/_masthead.scss b/site/assets/scss/_masthead.scss
@@ -16,7 +16,7 @@
 
   .bd-code-snippet {
     margin: 0;
-    border-color: var(--bs-color-border-emphasized);
+    border-color: var(--bs-color-border-default);
     border-width: 1px;
     @include border-radius(calc(.5rem - 1px));
   }

diff --git a/site/assets/scss/_search.scss b/site/assets/scss/_search.scss
@@ -29,7 +29,7 @@
   --docsearch-key-shadow: null;
   // --docsearch-footer-height;
   --docsearch-footer-background: transparent;
-  --docsearch-footer-shadow: 0 -1px var(--bs-border-color);
+  --docsearch-footer-shadow: 0 -1px var(--bs-color-border-emphasized);
 }
 
 .bd-search {
@@ -50,7 +50,7 @@
 }
 
 .DocSearch-Modal {
-  border: var(--bs-border-width) solid var(--bs-color-border-emphasized);
+  border: var(--bs-border-width) solid var(--bs-color-border-default);
   @include border-radius(0, 0);
 }
 
@@ -98,7 +98,7 @@
 }
 
 .DocSearch-Form {
-  box-shadow: var(--bs-color-border-emphasized) 0 0 0 .125rem inset;
+  box-shadow: var(--bs-color-border-default) 0 0 0 .125rem inset;
   @include border-radius(0, 0);
 
   &:focus-within {

diff --git a/site/assets/scss/_tarteaucitron.scss b/site/assets/scss/_tarteaucitron.scss
@@ -38,7 +38,7 @@
   font-weight: $font-weight-bold;
   color: $white;
   background: $black;
-  border-top: var(--bs-border-width) solid var(--bs-color-border-emphasized);
+  border-top: var(--bs-border-width) solid var(--bs-color-border-default);
 
   &[style*="display: block"] {
     display: flex !important; // stylelint-disable-line declaration-no-important

diff --git a/site/assets/scss/_toc.scss b/site/assets/scss/_toc.scss
@@ -66,7 +66,7 @@
     nav {
       padding: $ouds-space-fixed-medium; // OUDS mod: instead of `1.25rem 1.25rem 1.25rem 1rem`
       background-color: var(--bs-tertiary-bg);
-      border: 1px solid var(--bs-border-color);
+      border: 1px solid var(--bs-color-border-emphasized);
       @include border-radius(var(--bs-border-radius));
     }
   }

diff --git a/site/content/docs/0.0/customize/color-palette.md b/site/content/docs/0.0/customize/color-palette.md
@@ -61,8 +61,8 @@ Bootstrap defines a color palette on its own. We worked on a mapping between Ora
 
 {{< callout danger >}}
 Some of the colors below do not belong to the Orange Unified Design System specifications.
-<!-- TODO LM: Decide how to link to the new DSM -->
-Please refer to our [color palette section](#palette)<!-- and to the [Color guidelines](https://unified-design-system.orange.com/472794e18/p/217ac6-colour/b/4705d3) on the Orange Unified Design System website-->.
+
+Please refer to our [color palette section](#palette) and to the [Color guidelines](https://unified-design-system.orange.com/472794e18/p/217ac6-color) on the Orange Unified Design System website.
 {{< /callout >}}
 
 {{< callout warning >}}
@@ -118,13 +118,13 @@ Sass cannot programmatically generate variables, so we manually created variable
 
 <h3>Example</h3>
 
-Here's how you should not use these in your Sass:
+Here's how you should use these in your Sass:
 
 ```scss
-.alpha { color: $purple; }
+.alpha { color: var(--bs-color-action-visited); } // And not `$ouds-color-decorative-amethyst-600` or `$ouds-color-action-visited-light` directly
 .beta {
-  color: $ouds-color-decorative-sun-100;
-  background-color: $indigo-900;
+  color: $ouds-color-decorative-sun-100; // Because we don't have any CSS variable but prefer avoid the decorative
+  background-color: var(--bs-color-bg-primary); // No hex code, no Sass variable
 }
 ```