Skip to content

Commit

Permalink
fix(review)
Browse files Browse the repository at this point in the history
------------

Co-authored-by: Hannah Issermann <[email protected]>
  • Loading branch information
louismaximepiton and hannahiss committed Nov 20, 2024
1 parent 5de5703 commit a006018
Show file tree
Hide file tree
Showing 9 changed files with 224 additions and 216 deletions.
30 changes: 15 additions & 15 deletions scss/_maps.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,22 @@ $ouds-elevations: (

// scss-docs-start ouds-maps-font
$ouds-font-sizes: (
dl: "/display-large",
dm: "/display-medium",
ds: "/display-small",
hxl: "/heading-xlarge",
hl: "/heading-large",
hm: "/heading-medium",
hs: "/heading-small",
bl: "/body-large",
bm: "/body-medium",
bs: "/body-small",
lxl: "/label-xlarge",
ll: "/label-large",
lm: "/label-medium",
ls: "/label-small",
cs: "/code-small",
cm: "/code-medium",
cs: "/code-small"
ls: "/label-small",
lm: "/label-medium",
ll: "/label-large",
lxl: "/label-xlarge",
bs: "/body-small",
bm: "/body-medium",
bl: "/body-large",
hs: "/heading-small",
hm: "/heading-medium",
hl: "/heading-large",
hxl: "/heading-xlarge",
ds: "/display-small",
dm: "/display-medium",
dl: "/display-large",
) !default;

$ouds-font-weights: (
Expand Down
2 changes: 1 addition & 1 deletion scss/_reboot.scss
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
// 2. As a best practice, apply a default `background-color`.
// 3. Prevent adjustments of font size after orientation changes in iOS.
// 4. Change the default tap highlight to be completely transparent in iOS.
// 5. Prevent faux-bold/italic maybe for some RTL fonts
// 5. Prevent faux-bold/italic especially for some RTL fonts
// See https://developer.mozilla.org/fr/docs/Web/CSS/font-synthesis

// scss-docs-start reboot-body-rules
Expand Down
3 changes: 3 additions & 0 deletions scss/_root.scss
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
--#{$prefix}font-size-label-large: #{px-to-rem($ouds-font-size-label-large)};
--#{$prefix}font-size-label-medium: #{px-to-rem($ouds-font-size-label-medium)};
--#{$prefix}font-size-label-small: #{px-to-rem($ouds-font-size-label-small)};
--#{$prefix}font-size-code-medium: #{px-to-rem($ouds-font-size-code-medium)};
--#{$prefix}font-line-height-display-large: #{divide($ouds-font-line-height-display-large-mobile, $ouds-font-size-display-large-mobile)};
--#{$prefix}font-line-height-display-medium: #{divide($ouds-font-line-height-display-medium-mobile, $ouds-font-size-display-medium-mobile)};
--#{$prefix}font-line-height-display-small: #{divide($ouds-font-line-height-display-small-mobile, $ouds-font-size-display-small-mobile)};
Expand All @@ -93,6 +94,7 @@
--#{$prefix}font-line-height-label-large: #{divide($ouds-font-line-height-label-large, $ouds-font-size-label-large)};
--#{$prefix}font-line-height-label-medium: #{divide($ouds-font-line-height-label-medium, $ouds-font-size-label-medium)};
--#{$prefix}font-line-height-label-small: #{divide($ouds-font-line-height-label-small, $ouds-font-size-label-small)};
--#{$prefix}font-line-height-code-medium: #{divide($ouds-font-line-height-label-small, $ouds-font-size-code-medium)};
--#{$prefix}font-letter-spacing-display-large: #{px-to-rem($ouds-font-letter-spacing-display-large-mobile)};
--#{$prefix}font-letter-spacing-display-medium: #{px-to-rem($ouds-font-letter-spacing-display-medium-mobile)};
--#{$prefix}font-letter-spacing-display-small: #{px-to-rem($ouds-font-letter-spacing-display-small-mobile)};
Expand All @@ -107,6 +109,7 @@
--#{$prefix}font-letter-spacing-label-large: #{px-to-rem($ouds-font-letter-spacing-label-large)};
--#{$prefix}font-letter-spacing-label-medium: #{px-to-rem($ouds-font-letter-spacing-label-medium)};
--#{$prefix}font-letter-spacing-label-small: #{px-to-rem($ouds-font-letter-spacing-label-small)};
--#{$prefix}font-letter-spacing-code-medium: #{px-to-rem($ouds-font-letter-spacing-code-medium)};
--#{$prefix}font-max-width-display-large: #{px-to-rem($ouds-size-max-width-type-display-large-mobile)};
--#{$prefix}font-max-width-display-medium: #{px-to-rem($ouds-size-max-width-type-display-medium-mobile)};
--#{$prefix}font-max-width-display-small: #{px-to-rem($ouds-size-max-width-type-display-small-mobile)};
Expand Down
Loading

0 comments on commit a006018

Please sign in to comment.