Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorted lang file alphabetically #69

Merged
merged 1 commit into from
Nov 28, 2024
Merged

sorted lang file alphabetically #69

merged 1 commit into from
Nov 28, 2024

Conversation

bluetom
Copy link
Member

@bluetom bluetom commented Nov 28, 2024

No description provided.

@bluetom bluetom added bug Something isn't working 4.5.1 labels Nov 28, 2024
@bluetom bluetom self-assigned this Nov 28, 2024
@bluetom bluetom linked an issue Nov 28, 2024 that may be closed by this pull request
@ferishili
Copy link
Contributor

Hi @bluetom,
I find Alex suggestion more practical, which disabled the phpcs.
What is your opinion on that?
https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/main/lang/en/theme_boost_union.php#L27-L29

When you are good with it, then we could also apply this to all other plugins.
BR

@bluetom
Copy link
Member Author

bluetom commented Nov 28, 2024

For (very) small files - like this one - I would prefer an alphabetical sort. With larger plugins I agree with Alex and you. There it makes sense to organize it semantically...
BR

@bluetom bluetom merged commit 1c1eed1 into master Nov 28, 2024
14 checks passed
@mtneug mtneug deleted the issue-68 branch November 28, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5.1 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lang string file not sorted correctly
2 participants