Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handleing and messaging + opencast api integration #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ferishili
Copy link
Contributor

@ferishili ferishili commented Jan 10, 2025

This PR fixes #26

Description

The error message shown when opening a video/series is very blur and it is not descriptive.
Also I have found out that this plugin still uses the old api calls which have been depricate long time ago.

Solution

  • The Opencast API (PHP Library) is now being used/integrated.
  • The Error messages shown now got a bit more meaningful details, so that the user knows more about what is happening if there is an error in two following cases:
    • If the opencast is down or not accessible
    • If the publication to extract video url is not ready or the configuration is incorrect.
      We don't need more to describe to users apart from these 2 cases, as this plugin play the role of presenting the video to the end-users.

TO TEST

  • Patch this PR
  • Make sure you have a course with at least an upload video via block plugin!
  • As we introduced the Opencast API integration, it is very helpful to test this PR throughly! means all functions as follows:
    • Check if the existing video in mod plugin still work/ behave as expected!
    • Try to create a new video with mod plugin.
    • Try to create a new series with mod plugin
  • To see the newly added error messages:
    • temporary change the opencast credentials in tool plugin and then try to open an existing video in mod plugin
    • Run a long workflow process on an uploaded video and try to access/create mod video out of that during the process and check the error message!

@ferishili ferishili added the enhancement New feature or request label Jan 10, 2025
@ferishili ferishili requested a review from bluetom January 10, 2025 14:41
@ferishili ferishili self-assigned this Jan 10, 2025
@ferishili ferishili changed the title Improve error handleing and messaging Improve error handleing and messaging + opencast api integration Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message for unpublished embedded videos
2 participants