Fixes Opencast-Moodle/moodle-filter_opencast#54 #55
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferishili
requested changes
Jan 10, 2025
| @@ -24,8 +24,11 @@ | |||
|
|
|||
| namespace filter_opencast\local; | |||
|
|
|||
| use core\check\performance\debugging; | |||
There was a problem hiding this comment.
Please remove this if it is not in use!
| // Endpoint to call the engage.ui url of presentation node. | ||
| // Make sure the api user has the rights to call that api endpoint. | ||
| $engageurlendpoint = '/api/info/organization/properties/engageuiurl'; | ||
| $result = json_decode($api->oc_get($engageurlendpoint), true); |
There was a problem hiding this comment.
Please use opencastapi (Opencast PHP Library) property: getOrgEngageUIUrl
So that would be something like this:
$api->opencastapi->baseApi->getOrgEngageUIUrl();
api->oc_get is no more recommened and it will be removed in near future!
| @@ -35,3 +35,4 @@ | |||
| $string['setting_uselti_desc'] = 'When enabled, Opencast videos are delivered through LTI authentication using the <strong>default Opencast video player</strong>. This is typically used alongside Secure Static Files in Opencast for enhanced security.'; | |||
| $string['setting_uselti_nolti_desc'] = 'To enable LTI Authentication for Opencast, you must configure the required credentials (Consumer Key and Consumer Secret) for this instance. Please do so via this link: {$a}'; | |||
| $string['setting_uselti_ocinstance_name'] = 'Opencast API {$a} Instance'; | |||
| $string['no_engageurl_error'] = 'No URL available. Please check if the api endpoint is available and if the api user has the proper rights.'; | |||
There was a problem hiding this comment.
We need to use a more comprehensive (not-technical) info here, as it might be displayed to the end-users and they for example cannot check the api or the user rights!
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.