Make sure teachers can't upload videos into arbitrary series in single-upload #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By only accepting the series param if on $courseid==$SITE->id.
justusdieckmann
changed the title
Merged
|
@NinaHerrmann did you read my review? Or did you just ignore it? |
|
As far as I can see you did not do any review on this PR, but mentioned it in the other PR? |
|
|
|
Yes I did! |
|
I would like to offer a meeting for you and Justus to explain the whole situation. |
|
|
|
ah. If you are doing a review you need to press submit. Otherwise no one sees your review :) |
|
I did, and that is why it says ferishili started a review :-) EDIT: you were right, the submit was missing. |
ferishili
reviewed
Mar 18, 2024
|
I am reverting it back before people cherry pick that, to make sure we are at the same page! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By only accepting the series param if $courseid==$SITE->id.