Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Update All fn Selector "Magic Values" Into Explicit fn Selector Calculation #442

Merged
merged 8 commits into from
Dec 10, 2024
Merged

ref: Update All fn Selector "Magic Values" Into Explicit fn Selector Calculation #442

merged 8 commits into from
Dec 10, 2024

Conversation

0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Dec 10, 2024 •
edited
Loading

Resolves #419

PR Checklist

  • Tests
  • Documentation
  • Changelog

@0xNeshi 0xNeshi self-assigned this Dec 10, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit d3d42a0
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67581ef3ae74b10008a9ace1

@0xNeshi 0xNeshi marked this pull request as ready for review December 10, 2024 09:44
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.6%. Comparing base (a19789a) to head (d3d42a0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/src/token/erc721/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc721/extensions/metadata.rs 30.7% <100.0%> (+19.6%) ⬆️
contracts/src/token/erc721/mod.rs 65.6% <0.0%> (ø)

@0xNeshi 0xNeshi requested a review from ggonzalez94 December 10, 2024 09:48
bidzyyys
bidzyyys reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @0xNeshi. Left small comment.

contracts/src/token/erc721/extensions/metadata.rs Outdated Show resolved Hide resolved
@0xNeshi 0xNeshi requested a review from bidzyyys December 10, 2024 11:00
bidzyyys
bidzyyys approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

qalisander
qalisander approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@0xNeshi 0xNeshi merged commit b279280 into main Dec 10, 2024
24 checks passed
@0xNeshi 0xNeshi deleted the clean-magic-values branch December 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qalisander qalisander qalisander approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

Assignees

@0xNeshi 0xNeshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Update All fn Selector "Magic Values" Into Explicit fn Selector Calculation
3 participants
@0xNeshi @bidzyyys @qalisander