feat: add ERC20FlashMint extension #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifechukwudaniel
requested review from
bidzyyys,
qalisander and
0xNeshi
as code owners
✅ Deploy Preview for contracts-stylus canceled.
|
✅ Deploy Preview for contracts-stylus canceled.
|
|
This is my initial draft |
0xNeshi
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Hi @Ifechukwudaniel!
Thanks for the contribution!
The PR overall looks good, let's polish it a bit
| pub fn _flash_fee_receiver(&self) -> Address { | ||
| Address::ZERO | ||
| } | ||
| } |
| pub fn _flash_fee_receiver(&self) -> Address { | ||
| Address::ZERO | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing integration tests
Co-authored-by: Nenad <[email protected]>
Co-authored-by: Nenad <[email protected]>
chore: fixed tab
Create erc20-flashloan.adoc
chore: fixes
|
@0xNeshi what do you think about the new implementation for the extension |
bidzyyys
reviewed
Dec 12, 2024
Co-authored-by: Daniel Bigos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: It is impossible to write any unit tests until it is possible to mock
contract::address()in tests (see #452).Resolves #355
PR Checklist