feat: erc721 consecutive extension #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # contracts/src/lib.rs # contracts/src/utils/math/alloy.rs # contracts/src/utils/math/mod.rs # contracts/src/utils/mod.rs
bidzyyys
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Looks good in a second pass. I agree with comments left by @alexfertel that are still to be resolved.
Co-authored-by: alexfertel <[email protected]>
alexfertel
approved these changes
Aug 8, 2024
bidzyyys
reviewed
Aug 8, 2024
| /// Erc721 contract storage. | ||
| Erc721 erc721; | ||
| /// Checkpoint library contract for sequential ownership. | ||
| Trace160 _sequential_ownership; |
There was a problem hiding this comment.
IMHO there is some inconsistency in naming, erc721 and than prefixed with _, like _sequential_ownership
bidzyyys
reviewed
Aug 8, 2024
bidzyyys
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Great job @qalisander!
I left some minor comments and nits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension matches the solidity implementation except one thing:
_owner_of_innerand_updatesome functions are duplicated from erc721 token standardResolves #68
PR Checklist