Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dret): fix update of privstate in dretevent #3898

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(dret): fix update of privstate in dretevent #3898

merged 1 commit into from
Nov 20, 2024

Conversation

wissygh
Copy link
Contributor

@wissygh wissygh commented Nov 19, 2024

  • ref: When an MRET instruction is executed, the virtualization mode V is set to MPV, unless MPP=3, in which case V remains 0

@wissygh wissygh added the cherry-pick needed This pull request needs to be cherry-picked to master label Nov 19, 2024
@wissygh wissygh marked this pull request as ready for review November 19, 2024 13:32
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 01dbb72

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
01dbb72 1.917 0.450 2.701 1.234 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
aecf601 1.917 0.450 2.701 1.237 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
03426fe 1.917 0.450 2.701 1.221 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
39d5540 1.917 0.450 2.701 1.235 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
92f3664 1.917 0.450 2.701 1.227 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
3e2285d 1.917 0.450 2.701 1.226 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

@wissygh wissygh added the do not merge Do not merge this pull request label Nov 20, 2024
@wissygh wissygh removed the do not merge Do not merge this pull request label Nov 20, 2024
@wissygh
fix(dret): fix update of privstate in dretevent
7232310 
 * shouldn't assert pristate.v when dret is executed and dcsr.prv is mmode
 * ref: When an MRET instruction is executed, the virtualization mode V is set to MPV, unless MPP=3, in which case V remains 0.
@wissygh wissygh changed the title fix(dret): don't assert privstate.V when dcsr.prv is mMode fix(dret): fix update of privstate in dretevent Nov 20, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 7232310

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
7232310 1.917 0.450 2.701 1.234 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
d6b0c0d
4adf8eb 1.917 2.701 1.229 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.387 3.261
aecf601 1.917 0.450 2.701 1.237 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
03426fe 1.917 0.450 2.701 1.221 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
39d5540 1.917 0.450 2.701 1.235 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

@Tang-Haojin Tang-Haojin merged commit b6cec43 into master Nov 20, 2024
9 checks passed
@Tang-Haojin Tang-Haojin deleted the fix-dret branch November 20, 2024 10:49
Tang-Haojin pushed a commit that referenced this pull request Nov 20, 2024
@wissygh @Tang-Haojin
fix(dret): fix update of privstate in dretevent (#3898)
710690a 
ref: When an MRET instruction is executed, the virtualization mode V
is set to MPV, unless MPP=3, in which case V remains 0
@Tang-Haojin Tang-Haojin mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinceforYy sinceforYy sinceforYy approved these changes

Assignees
No one assigned
Labels
cherry-pick needed This pull request needs to be cherry-picked to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wissygh @XiangShanRobot @sinceforYy @Tang-Haojin