Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Glossary and add meta descriptions #7

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Create Glossary and add meta descriptions #7

merged 3 commits into from
Mar 28, 2022

Conversation

capjamesg
Copy link
Contributor

@capjamesg capjamesg commented Mar 7, 2022

This PR copies the language from the glossaries of the two papers listed below to form the basis of a Glossary page.

This page was suggested in Issue #1 and this contribution was made in response to a discussion with @mtom55.

This PR provides HTML IDs for each section on the glossary page, making it easy to link to each asset.

We might want to consider breaking out definitions into different pages should the glossary get sufficiently long.

This PR also adds meta descriptions to pages without them.

@capjamesg capjamesg changed the title Glossary v1 Create Glossary and add meta descriptions Mar 7, 2022
@aliblackwell
Copy link
Collaborator

This looks good @capjamesg, turns out permalinks require a slash at the end, otherwise the built page gets called glossary rather than glossary.html 🤷

I also deleted the duplicate sitemap.njk and robots.njk files at the website root which re-appeared in a previous commit.

Netlify build previews will help us resolve issues like this.

Was there a reason the page didn't get put in a nav? We could add it to the footer nav by editing /src/_data/navigation.json. I only didn't in case there was a reason you didn't want to make it public yet.

@thescientist13
Copy link
Collaborator

Just wanted to share now @capjamesg that if you basically make any update to this branch (and / or felt like updating with main branch), the new Deploy Previews I just setup should run and then we should be able to get a nice preview URL of your work to see and share. 🌟

@ssddanbrown ssddanbrown merged commit d607515 into main Mar 28, 2022
@ssddanbrown
Copy link
Collaborator

All looked great to me!

Have now merged and followed it up with 3e410ec and cbd0064 to implement @aliblackwell's suggestion of adding a link to the footer, in addition to some minor punctuation alignment changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants