fix/speech

[NeonJarbas]

bumps ovos utils to include OpenVoiceOS/ovos-utils#14

bumps ovos plugin manager to include OpenVoiceOS/ovos-plugin-manager#26

removes a hack with a TODO

refactors out the global config variable

wraps the fallback tts into a try: except:

[ChanceNCounter]

Goodbye, regex. I don't really get the removed hack. Was that compensating for Picroft, Pi, or Raspbian, and do we care?

[j1nx]

OK, will follow all related PR's, bump, test and report back.

[NeonDaniel]

If removed patch is no longer patching an RPi issue, this seems fine; otherwise consider putting it in a method with a config option to suppress splitting sentences

[j1nx]

Testing this PR however following error is for all TTS output.

2022-02-09 19:56:15.139 - OVOS - mycroft.audio.speech:mute_and_speak:104 - ERROR - TTS execution failed.
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/mycroft/audio/speech.py", line 99, in mute_and_speak
    tts.execute(utterance, ident, listen)
  File "/usr/lib/python3.8/site-packages/ovos_plugin_manager/templates/tts.py", line 418, in execute
    self._execute(sentence, ident, listen, **kwargs)
  File "/usr/lib/python3.8/site-packages/ovos_plugin_manager/templates/tts.py", line 449, in _execute
    audio_file, phonemes = self._synth(sentence, sentence_hash, **kwargs)
  File "/usr/lib/python3.8/site-packages/ovos_plugin_manager/templates/tts.py", line 506, in _synth
    audio.path, phonemes = self.get_tts(sentence, str(audio), **kwargs)
  File "/usr/lib/python3.8/site-packages/ovos_tts_plugin_mimic2/__init__.py", line 43, in get_tts
    results = requests.get(self.url, params=params).json()
  File "/usr/lib/python3.8/site-packages/requests/models.py", line 900, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2022-02-09 19:56:15.216 - OVOS - ovos_plugin_manager.templates.tts:_play:118 - ERROR - 'NoneType' object has no attribute 'split'
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/ovos_plugin_manager/templates/tts.py", line 107, in _play
    self.p = play_audio(data)
  File "/usr/lib/python3.8/site-packages/ovos_utils/sound/__init__.py", line 22, in play_audio
    ext = uri.split("?")[0].split(".")[-1]
AttributeError: 'NoneType' object has no attribute 'split'

Used the default mycroft setup route utilizing the Mimic2 and selene pairing.

[j1nx]

Following error is within voice.log but not sure if this related.

2022-02-09 19:58:47.774 - OVOS - mycroft.client.speech.listener:run:396 - DEBUG - Config has changed, reloading...
2022-02-09 19:58:47.817 - OVOS - mycroft.client.speech.listener:run:97 - ERROR - Exception in AudioProducer
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/mycroft/client/speech/listener.py", line 72, in run
    audio, lang = self.loop.responsive_recognizer.listen(
  File "/usr/lib/python3.8/site-packages/mycroft/client/speech/mic.py", line 802, in listen
    ww_data, lang = self._wait_until_wake_word(source, sec_per_buffer)
TypeError: cannot unpack non-iterable NoneType object

[JarbasAl]

@j1nx

thats mimic2 plugin failing, all the errors are just logs but actually handled in code, try out OpenVoiceOS/ovos-plugin-manager#27 and see if it improves things, if fallback TTS is not triggering with that + #49 then we have a new issue

the second thing is a new issue, OpenVoiceOS/ovos-listener#22