-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve doc: back-tick fix, packet/payload, etc #1
Open
jmark-ovpn
wants to merge
2
commits into
OpenVPN:master
Choose a base branch
from
jmark-ovpn:jmark_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid using "payload" here since we use the same term later for the VPN playload inside the OpenVPN packets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flichtenheld I see what you mean. As in the example of layout:
-opcode- || -session_id- || -packet_id- || auth_tag || * payload *
and in the chart heading in the "Overview of OPCODEs" section.
My suggestion here is that the use of "payload" in both of those examples is unconventional. My usage follows the convention that the payload is what comes after the headers. And the body of the section you identify in the comment only addresses the payload, not the full packet. To reconcile that with the unconventional usage, I would suggest calling the additional data that follows opcodes and other stuff at the front of the payload "more data", "control data", "optional data", "extra data", or "vpn traffic" depending on the specific context. I would be happy to add those changes to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple references for conventional vs unconventional use of payload:
https://en.wikipedia.org/wiki/Network_packet
https://networkengineering.stackexchange.com/questions/35016/whats-the-difference-between-frame-packet-and-payload
and there are more by googling packet payload.