Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default sample size #14

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Update default sample size #14

merged 1 commit into from
Jan 22, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Jan 22, 2024

In this PR, we update the default sample size.

More specifically, in the serial, non-noisy case, we change the default sample size used for linear models from p + 1 to p + 2 (where p = len(x)).

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0faac1) 78.67% compared to head (1fbea80) 78.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   78.67%   78.71%   +0.03%     
==========================================
  Files          68       68              
  Lines        4953     4957       +4     
==========================================
+ Hits         3897     3902       +5     
+ Misses       1056     1055       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosg janosg merged commit a5895dc into main Jan 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants