Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in options processing #11

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Small fix in options processing #11

merged 1 commit into from
Jan 20, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented Jan 20, 2024

Small fix in options processing. The bug raised a TypeError when a user overrides an option with default value None.

@janosg janosg requested a review from mpetrosian January 20, 2024 12:09
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f3d567) 78.64% compared to head (624c493) 78.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files          68       68           
  Lines        4944     4945    +1     
=======================================
+ Hits         3888     3889    +1     
  Misses       1056     1056           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosg janosg merged commit 055d7a2 into main Jan 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants