Fix tests/probes/sysctl_all #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test will now automatically adapt to the list of readable variables and won't break every time a new root-readable variable is introduced in kernel.
evgenyz
commented
Nov 8, 2023
| # sysctl has duplicities in output | ||
| # hide permission errors like: "sysctl: permission denied on key 'fs.protected_hardlinks'" | ||
| # kernel parameters might use "/" and "." separators interchangeably - normalizing | ||
| sysctl -a --deprecated 2> /dev/null | tr "/" "." | cut -d "=" -f 1 | tr -d " " | sort -u > "$sysctlNames" |
There was a problem hiding this comment.
The key is the removal of N argument. If we try and query for the values as well we'll get the list consistent with what the probe could get access to.
jan-cerny
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test will now automatically adapt to the list of readable variables and won't break every time a new root-readable variable is introduced in kernel.
Fixes: #2049