Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material_import.py, Texture Alpha node to Principled BSDF Alpha #260

Closed
wants to merge 4 commits into from

Conversation

rizzntine
Copy link
Contributor

added change to create_vertex_material so that we can connect the Texture Alpha node to Principled BSDF Alpha node

added change to create_vertex_material so that we can connect the Texture Alpha node to Principled BSDF Alpha node
@Tarcontar
Copy link
Collaborator

Hi, thanks for your contribution!
This results for the file i tested in this configuration:
image
I dont think this is the desired behaviour.
Could you please show how this looks for the file you tested?

@rizzntine
Copy link
Contributor Author

Hi! Thanks for the test!
Functionally, the behaviour is functioning as intended - or it would be, i just noticed that the second image is connecting the color node to the alpha - that is definitely not the intent. It should connect Alpha to Alpha.
Untitled
Most of my testing scope was focused on C&C Generals Faction Buildings which used transparent materials, eg. The USA Airfield (ABARFRCCMD.w3d), China's War Factory (NBWARFACT.w3d)...

I'm afraid I have limited time to look into this but I'll attempt to take a deeper dive into this and resolve the microscopic issues before they turn macro. What was your tested configuration in question?

@Michaelschnabel-DM
Copy link
Contributor

@rizzntine Hi, i tried to properly link the texture:
image

Could you please check if this still results in the correct behaviour? I actually do not really have a lot of generals models lying around.

@rizzntine
Copy link
Contributor Author

Hi! Yes, it links fine now, splendid!
ApplicationFrameHost_ANLbrco5Db
The current patch fork however does not have the multiple material rework that has been done on the fork since, so it looks like this. I've went ahead and implemented the node tree manipulation into the master branch of the fork with, here is how the result looks now:
ApplicationFrameHost_YmRxOsdFoo
Therefore, I will be closing this pull request in favor of moving to the more functional one.

@rizzntine rizzntine closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants