Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update buildeps for newer package name #975

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Mar 6, 2022

fixes issue #974

@pchev
Copy link
Contributor

pchev commented Mar 7, 2022

This is not enough, libgtk2.0-dev also need to be replaced by libgtk-3-dev.
But it may work because it is already a dependency of libwxgtk3.0-gtk3-dev, in this case it is better to remove any libgtk...

Can you try with:
Build-Depends: debhelper (>= 9), cmake, libwxgtk3.0-dev | libwxgtk3.0-gtk3-dev, libcfitsio-dev, libopencv-dev, libusb-1.0-0-dev, libudev-dev, libv4l-dev, libnova-dev, libcurl4-gnutls-dev

I will also test that on old Debian version without GTK3.

@alxgomz
Copy link
Contributor Author

alxgomz commented Mar 7, 2022

yes removing libgtk2.0-dev works on debian 11

@agalasso agalasso requested a review from pchev March 8, 2022 05:52
@pchev
Copy link
Contributor

pchev commented Mar 8, 2022

This change work for me, OK to commit.

As we are on this subject, I have two other change to do to the debian files.

  • change compat to version 10
  • for simplification use the unversioned README.txt in docs
    I make another PR after this one is merged.

@agalasso agalasso merged commit c38c446 into OpenPHDGuiding:master Mar 8, 2022
@TallFurryMan
Copy link
Contributor

cmake_modules/PHD2Packaging.cmake also needs patching in order to buid the deb file with cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants