Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance contrast for very low contrast images. #1162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eyeke2
Copy link
Contributor

@Eyeke2 Eyeke2 commented Jan 26, 2024

This adjustment prevents the frames from being displayed as all-white, which is a visually unpleasant artifact commonly encountered in very dark frames without visible stars. By slightly increasing the maximum value when the difference between min and max values is minimal, we improve the visibility of image details while avoiding the all-white display issue.

@agalasso agalasso requested review from agalasso and bwdev01 January 27, 2024 17:14
@agalasso
Copy link
Contributor

This seems promising, thanks for the PR. Could you suggest some way to demonstrate the effect of the change so we can see the effect? For example, you could attach a camera image (file > save image), then reviewers could build the branch and test with the camera image to see the improvement.

@Eyeke2
Copy link
Contributor Author

Eyeke2 commented Jan 27, 2024

This seems promising, thanks for the PR. Could you suggest some way to demonstrate the effect of the change so we can see the effect? For example, you could attach a camera image (file > save image), then reviewers could build the branch and test with the camera image to see the improvement.

Unfortunately, my QHYIII290 camera which I used in testing, where this "white screen" happened is now broken. I will try to create a simulated camera image which will show the effect and attach the file (it will require ASCOM camera simulator which is able to load an image file).

@Eyeke2
Copy link
Contributor Author

Eyeke2 commented Jan 27, 2024

Actually, I'm not sure if this is sufficient for fixing the white-screen issue for good. It's still possible to generate a dark image with very small difference between min and max pixel values to cause PHD2 to show all-white screen (or nearly all-white), even when screen gamma is set to the rightmost position. If you have other idea how to fix it, I'd like to know. I have addressed it for my specific camera, and haven't thought about more general solution.

the frames from being displayed as all-white, which is a visually
unpleasant artifact commonly encountered in very dark frames without
visible stars. By slightly increasing the maximum value when the
difference between min and max values is minimal, we improve the
visibility of image details while avoiding the all-white display issue.

Signed-off-by: Leo Shatz <[email protected]>
@Eyeke2 Eyeke2 force-pushed the whitescreen_fix branch from 18d5e03 to db0e3cc Compare April 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants