Use system eigen3 by default (#1158)

Remove the bundled eigen3 and use the system's eigen3 by default. It is no longer
necessary to specify -DUSE_SYSTEM_EIGEN3=ON.

Also, add running of unit tests to the Windows and Mac builds as this exercises the
eigen code.

build/build-mac

@@ -113,5 +113,8 @@ make -j$cores
 
 check_library_dependencies
 
+# make sure tests all pass
+ctest
+
 zip -r "$ZIPFILE" PHD2.app
 chmod 644 "$ZIPFILE"

build/build-win

@@ -66,6 +66,7 @@ fi
 
 CMD="/c/Windows/System32/cmd.exe"
 CMAKE='/c/Program Files/CMake/bin/cmake.exe'
+CTEST='/c/Program Files/CMake/bin/ctest.exe'
 ISCC="/c/Program Files (x86)/Inno Setup 5/ISCC.exe"
 
 CMAKE_W=$(cygpath -w "$CMAKE")
@@ -80,24 +81,21 @@ vcpkg_args=()
 if [[ $VCPKG_ROOT ]]; then
     vcpkg_args+=(-DVCPKG_ROOT=$VCPKG_ROOT)
 fi
+
 mkdir -p tmp
-(
-    cd tmp
+cd tmp
 
-    cat >run_cmake.bat <<EOF
+cat >run_cmake.bat <<EOF
 "$CMAKE_W" -Wno-dev -G "Visual Studio 17" -A Win32 ${vcpkg_args[@]} "-DwxWidgets_PREFIX_DIRECTORY=%WXWIN%" ..
 EOF
-
-    "$CMD" /c run_cmake.bat
-)
+"$CMD" /c run_cmake.bat
 
 # generate phd2.iss and README.txt in tmp, one level up from Release/
-sed -e "s/@VERSION@/$V/g" phd2.iss.in >tmp/phd2.iss
-sed -e "s/@VERSION@/$V/g" README-PHD2.txt.in >tmp/README-PHD2.txt
+sed -e "s/@VERSION@/$V/g" ../phd2.iss.in >phd2.iss
+sed -e "s/@VERSION@/$V/g" ../README-PHD2.txt.in >README-PHD2.txt
+
+"$CMAKE" --build . --config Release
 
-(
-    cd tmp
-    "$CMAKE" --build . --target phd2 --config Release
+"$CTEST" --build-config Release
 
-    "$ISCC" phd2.iss /F"${INSTALLER}"
-)
+"$ISCC" phd2.iss /F"${INSTALLER}"

cmake_modules/compiler_options.cmake

@@ -42,9 +42,7 @@ if(WIN32)
 endif()
 
 # these options allow to use system libraries
-option(USE_SYSTEM_CFITSIO "Enable this option here or in cmake call if you want to use system's cfitsio." OFF)
 option(USE_SYSTEM_LIBUSB "Enable this option here or in cmake call if you want to use system's libUSB." OFF)
-option(USE_SYSTEM_EIGEN3 "Enable this option here or in cmake call if you want to use system's Eigen3." OFF)
 option(USE_SYSTEM_GTEST "Enable this option here or in cmake call if you want to use system's Gtest." OFF)
 option(USE_SYSTEM_LIBINDI "Enable this option here or in cmake call if you want to use system's libindi." OFF)
 

debian/rules

@@ -28,5 +28,5 @@ include /usr/share/dpkg/default.mk
 #	-DCMAKE_LIBRARY_PATH=$(DEB_HOST_MULTIARCH)
 
 override_dh_auto_configure:
-	dh_auto_configure --  -DUSE_SYSTEM_LIBINDI=1 -DUSE_SYSTEM_EIGEN3=1 -DUSE_SYSTEM_GTEST=1 -DUSE_SYSTEM_LIBUSB=1
+	dh_auto_configure --  -DUSE_SYSTEM_LIBINDI=1 -DUSE_SYSTEM_GTEST=1 -DUSE_SYSTEM_LIBUSB=1
 

thirdparty/thirdparty.cmake

@@ -495,21 +495,10 @@ endif()
 
 if(WIN32)
   set(EIGEN_SRC ${VCPKG_INCLUDE}/eigen3)
-elseif(USE_SYSTEM_EIGEN3)
+else()
   find_package(Eigen3 REQUIRED)
   set(EIGEN_SRC ${EIGEN3_INCLUDE_DIR})
   message(STATUS "Using system's Eigen3.")
-else(USE_SYSTEM_EIGEN3)
-  set(EIGEN eigen-eigen-67e894c6cd8f)
-  set(eigen_root ${thirdparties_deflate_directory}/${EIGEN})
-  if(NOT EXISTS ${eigen_root})
-    # untar the dependency
-    execute_process(
-      COMMAND ${CMAKE_COMMAND} -E tar xjf ${thirdparty_dir}/${EIGEN}.tar.bz2
-      WORKING_DIRECTORY ${thirdparties_deflate_directory})
-  endif()
-
-  set(EIGEN_SRC ${eigen_root})
 endif()