Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage fix #4564

Merged
merged 7 commits into from
Sep 17, 2020
Merged

Test coverage fix #4564

merged 7 commits into from
Sep 17, 2020

Conversation

madhavajay
Copy link
Collaborator

@madhavajay madhavajay commented Sep 16, 2020

Description

PR to this PR: #4553

Fixed lint issue
Fixed failing test_Floatconversion test

Affected Dependencies

None

How has this been tested?

Locally in py3.6, py3.7 & py3.8 and CI

Checklist

@madhavajay madhavajay requested a review from a team as a code owner September 16, 2020 23:42
@madhavajay madhavajay requested review from iamtrask and wip-abramson and removed request for a team September 16, 2020 23:42
- Fixed failing test_Floatconversion test
- Removed @pytest.mark.xfail
@madhavajay
Copy link
Collaborator Author

Not sure what I did to fix the docs lint issue.
I was unable to replicate it on my machine, and then I tried to add doc8 and add some max-line-length configuration but it wouldnt pass in CI, so i removed it for now.

Issue is here:
PyCQA/doc8#48

@madhavajay madhavajay added the 0.3 label Sep 17, 2020
@madhavajay madhavajay mentioned this pull request Sep 17, 2020
4 tasks
@iamtrask iamtrask merged commit e9903b8 into syft_0.3.0 Sep 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the test-coverage-fix branch September 17, 2020 14:42
tudorcebere pushed a commit to tudorcebere/PySyft that referenced this pull request Sep 19, 2020
* add pprint test for Specific

* add tests for _deserialize

* add serde test for RunFunctionOrConstructorAction

* add tests for object search permission update

* address comments

- Removed @pytest.mark.xfail

Co-authored-by: Jasopaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants