Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poseidon BIG update #3468

Merged
merged 33 commits into from
Aug 7, 2021
Merged

Poseidon BIG update #3468

merged 33 commits into from
Aug 7, 2021

Conversation

ya4ept
Copy link
Contributor

@ya4ept ya4ept commented Jul 15, 2021 •
edited
Loading

Trying to fix Poseidon for twRO, vRO, cRO, jRO

  • minimum twRP support
  • minimum vRO support
  • minimum cRO support
  • minimum jRO support
  • minimum kRO support
  • minimum kRO Zero support
  • Dev mode do not responding to GG request
  • Dev mode does not show NPCs and Poring
  • start-poseidon.exe takes no arguments: start-poseidon.exe --file=test.txt
  • update Poseidon version

ya4ept added 6 commits July 12, 2021 02:55
@ya4ept
poseidon
a7e8991 
- fix `0B60` package
- added new `twRO_2021-06-21` serverType in poseidon
- added `0B60` support (account_server_info)
@ya4ept
poseidon
5e208a5 
- fix `099d` (received_characters)
@ya4ept
poseidon
9509bdf 
code cleanup: replaced "0x00 0x69" with "0x0069" to make it easier to search for packages throughout the code
@ya4ept
poseidon
a87c284 
add '0AC5' support (received_character_ID_and_Map)
@ya4ept
poseidon
a597228 
add '0436' support (map_login)
@ya4ept
replaced timestamp with hh:mm:cc
957b517
ya4ept
ya4ept commented Jul 15, 2021
View reviewed changes
control/poseidon.txt Outdated Show resolved Hide resolved
alisonrag added 9 commits July 15, 2021 16:39
@alisonrag
poseidon
d44c642 
fix charblocksize
@alisonrag
change initial map
626d272 
53 111 is the novice ground start, somewhere in the time someone changed the map
@alisonrag
poseidon
e926dc0 
update and fix debug packets
@alisonrag
Update servertypes.txt
685ab7b
@alisonrag
remove charblocksize from poseidon.txt
8b056b8
@alisonrag
replace Globals IDs value with real IDs
9aa4382
@alisonrag
poseidon
5686134
@alisonrag
poseidon
95c8dc9 
update
@alisonrag
poseidon
dc062bb 
add 0B04 reply
@alisonrag
poseidon
e21624f 
add 0b07 packet
@ya4ept
Copy link
Contributor Author

ya4ept commented Jul 17, 2021

if you enable debug in poseidon and write a message to the general chat in the client, then two identical messages are displayed in the console
image

@alisonrag
Copy link
Contributor

alisonrag commented Jul 17, 2021 •
edited
Loading

if you enable debug in poseidon and write a message to the general chat in the client, then two identical messages are displayed in the console
image

this is because of double visualDump
1 - when receive packet if debug = 1
2 - when unknown packet and char = 'poseidon dev'

should be fixed at:
f915fdd

alisonrag and others added 2 commits July 17, 2021 13:01
@alisonrag
poseidon
f915fdd 
fix duplicated dumps when debug is enabled
@ya4ept
translation
8e6d88c
@ya4ept
Copy link
Contributor Author

ya4ept commented Jul 17, 2021

let's change the version of poseidon
Starting Poseidon 2.1

@ya4ept
Copy link
Contributor Author

ya4ept commented Jul 18, 2021

@alisonrag, let's debug outgoing messages? Sometimes it's helpful to see exactly what a poseidon is answering.

@alisonrag
Copy link
Contributor

@alisonrag, let's debug outgoing messages? Sometimes it's helpful to see exactly what a poseidon is answering.
added
image

@alisonrag
Copy link
Contributor

alisonrag commented Jul 28, 2021 •
edited
Loading

  • start-poseidon.exe takes no arguments: start-poseidon.exe --file=test.txt

if i'm not wrong poseidon.pl was updated here to support command line arguments:
#1273
and the start-poseidon.exe was not rebuild using this new poseidon.pl

@alisonrag
Copy link
Contributor

  • minimum jRO support

added

@ya4ept
Copy link
Contributor Author

ya4ept commented Jul 30, 2021 •
edited
Loading

  • start-poseidon.exe takes no arguments: start-poseidon.exe --file=test.txt

if i'm not wrong poseidon.pl was updated here to support command line arguments:
#1273
and the start-poseidon.exe was not rebuild using this new poseidon.pl

You're wrong. start-poseidon.exe - does not contain any data from poseidon.pl, this is just a link to the file src\Poseidon\poseidon.pl. It does not need to be generated every time poseidon.pl changes.

I think we have a bug somewhere inside the "script-launcher" logic. It is not designed for passing command line arguments.

Let's fix it here #3497

@OpenKore OpenKore deleted a comment from timelinebk9x Aug 7, 2021
@ya4ept
Copy link
Contributor Author

ya4ept commented Aug 7, 2021 •
edited
Loading

Dev mode do not responding to GG request

this works fine (checked on twRO)
let's merge

@ya4ept ya4ept marked this pull request as ready for review August 7, 2021 02:08
@ya4ept ya4ept changed the title Poseidon update Poseidon BIG update Aug 7, 2021
@ya4ept ya4ept merged commit aead4ad into master Aug 7, 2021
@ya4ept ya4ept deleted the poseidon branch August 7, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonrag alisonrag alisonrag approved these changes

Assignees
No one assigned
Labels
feature request server: cRO server: twRO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ya4ept @alisonrag