Adapted megatronlm server implementation for interacting with lm eval… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlaudiaTH
commented
Aug 3, 2023
megatron/tokenizer/tokenizer.py
Outdated
| @@ -43,7 +43,8 @@ def build_tokenizer(args): | |||
| elif args.tokenizer_type == "OpenGPTX-PretrainedHFTokenizer": | |||
| tokenizer = PretrainedHFTokenizer.instantiate_from_file_or_name(model_file_or_name=args.tokenizer_model) | |||
| elif args.tokenizer_type == "OpenGPTX-SPTokenizer": | |||
| tokenizer = SPTokenizer.instantiate_from_file_or_name(model_file_or_name=args.tokenizer_model) | |||
| #tokenizer = SPTokenizer.instantiate_from_file_or_name(model_file_or_name=args.tokenizer_model) | |||
| tokenizer = _GPTXSentencePieceTokenizer(args.tokenizer_model) | |||
There was a problem hiding this comment.
ToDo: The _GPTXSentencePieceTokenizer is used for inference.
KlaudiaTH
commented
Aug 4, 2023
megatron/text_generation_server.py
Outdated
| @@ -164,48 +179,60 @@ def put(self): | |||
| if len(prompts) > 1: | |||
| return "When doing beam_search, batch size must be 1" | |||
|
|
|||
| stop_token=50256 | |||
| stop_token = 3 | |||
There was a problem hiding this comment.
Setting this to a constant 3 is wrong. I haven't tested generation yet, but I guess this should be the ID of the EOD token, so we need to get it from the tokenizer.
|
Marking as stale. No activity in 60 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… harness client