Sanitize theme code input in BuildThemesCommand for static content de…

…ployment and improve success/error messaging
OpenForgeProject · Dec 20, 2024 · f549144 · f549144
1 parent 0c25f3d
commit f549144
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Console/Command/BuildThemesCommand.php b/src/Console/Command/BuildThemesCommand.php
@@ -96,12 +96,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
             // Run static content deploy
             $io->section("Running 'magento setup:static-content:deploy -t $themeCode -f'... Please wait.");
-            exec("php bin/magento setup:static-content:deploy -t $themeCode -f", $outputLines, $resultCode);
+            $sanitizedThemeCode = escapeshellarg($themeCode);
+            exec("php bin/magento setup:static-content:deploy -t $sanitizedThemeCode -f", $outputLines, $resultCode);
             $io->writeln($outputLines);
             if ($resultCode === 0) {
-                $io->success("'magento setup:static-content:deploy -t $themeCode -f' has been successfully executed.");
+                $io->success("'magento setup:static-content:deploy -t $sanitizedThemeCode -f' has been successfully executed.");
             } else {
-                $io->error("'magento setup:static-content:deploy -t $themeCode -f' failed. Please check the output for more details.");
+                $io->error("'magento setup:static-content:deploy -t $sanitizedThemeCode -f' failed. Please check the output for more details.");
             }
 
             // Clean the output before the next theme is running