4. Improve logging on session related errors #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanib
changed the title
johanib
force-pushed
the
feature/4.log-more-session-errors
branch
3 times, most recently
from
fd46dc7 to
428cdd2
Compare
johanib
changed the title
johanib
force-pushed
the
feature/implement-session-required-atttribute
branch
from
44e890a to
0e18752
Compare
Prior to this change there we weren't able to keep track of sessions that got lost. This change allows us to see every time a session is created and distinguish them by their correlation id. Log an error on a route that requires an active session when there is none Prior to this change all routes were able to called, even though the user might not have had an active session This change will start logging errors when the session wasn't found, or is in an unexpected state Prior to this change session information got lost. We had no way of tracking down what happened to user sessions in the logs. This change logs whether a session existed and if it's in a valid state. Log information is enriched with a correlation id to be able to distinguish them. See https://www.pivotaltracker.com/n/projects/1163646/stories/188205214
johanib
force-pushed
the
feature/4.log-more-session-errors
branch
from
428cdd2 to
76473db
Compare
MKodde
reviewed
Nov 21, 2024
| return null; | ||
| } | ||
|
|
||
| return substr(hash('sha256', $sessionCookie.$this->correlationIdSalt), 0, 8); |
There was a problem hiding this comment.
This is now in spec with @pmeulen s request found here: #210 (comment)
MKodde
approved these changes
Nov 21, 2024
pmeulen
approved these changes
Nov 29, 2024
pmeulen
merged commit 98f4da6
into
feature/implement-session-required-atttribute
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change there we weren't able to keep track of sessions that got lost.
This change allows us to see every time a session is created and distinguish them by their correlation id.
Log an error on a route that requires an active session when there is none
Prior to this change all routes were able to called, even though the user might not have had an active session
This change will start logging errors when the session wasn't found, or is in an unexpected state
Prior to this change session information got lost. We had no way of tracking down what happened to user sessions in the logs.
This change logs whether a session existed and if it's in a valid state. Log information is enriched with a correlation id to be able to distinguish them.
See https://www.pivotaltracker.com/n/projects/1163646/stories/188205214