Tweak dependabot & fix dev bug #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
approved these changes
Nov 21, 2024
|
I copied this from another project of ours, which used dependabot on
gitlab.
I haven't verified personally if it works.
…On Thu, Nov 21, 2024 at 7:19 PM Tim van Dijen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dependabot.yml
<#222 (comment)>
:
> +version: 2
+updates:
+ - package-ecosystem: "composer"
+ directory: "/"
+ ignore:
+ - dependency-name: "symfony/*"
+ update-types: ["version-update:semver-major"]
@johanib <https://github.com/johanib> Have you verified that this
actually works? Because I've been struggling with this same issue and
nothing seems to work...
https://github.com/simplesamlphp/simplesamlphp/blob/master/.github/dependabot.yml#L18-L27
There are many bug reports in the dependabot-repo related to this, but
they don't seem to pick this up:
dependabot/dependabot-core#10122
<dependabot/dependabot-core#10122>
—
Reply to this email directly, view it on GitHub
<#222 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOOM5NOSEOMZMEV33TTRSA32BYP2BAVCNFSM6AAAAABRYQ6BYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJSGI4TSMJWGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Prior to this change, dependabot would create pr's to upgrade from Symfony 6.4 to Symfony 7.1. We don't want this, because 7.1 will be eol in a couple of months, which can the increase maintenance burden. We will upgrade to 7.4 lts once it is released.
johanib
force-pushed
the
feature/tame-dependabot
branch
from
7bbe47e to
6bc53df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, dependabot would create pr's to upgrade from Symfony 6.4 to Symfony 7.1. We don't want this, because 7.1 will be eol in a couple of months, which can the increase maintenance burden. We will upgrade to 7.4 lts once it is released.