Upgrade the app to use Symfony 6 and PHP 8.2 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before upgrading to SF6 and upgrading all dependencies, I opted to first upgrade the qa tooling. They will not pass by any means at this point.
We now use our own docker based devconf
If we want code coverage stats, we can use scrutenizer for that purpose
The legacy folder was renamed to openconext (as decided to be the way forward) The .env files only contained env overrides and allowed for setting the secret
That more closesly matches the modern symfony ways The webpack setup needed some small tweaking in order to keep things in a functioning state
This should have resulted in 500 errors in the tiqr app previously.
Level 8 and 9 have mostly been ignored as most of the warnings where hailing from the behat contexts
MKodde
force-pushed
the
feature/rejuvination
branch
from
e96cafb to
03f96f7
Compare
We have a test folder, but there are no tests. The folder is kept, and PHP Unit is standing by for future development where we might want to utilize PHP unit testing
MKodde
force-pushed
the
feature/rejuvination
branch
6 times, most recently
from
7c1ec80 to
771aa69
Compare
MKodde
force-pushed
the
feature/rejuvination
branch
from
a8f3202 to
cc17ef9
Compare
KarsanHAM
reviewed
Jan 18, 2024
composer.json
Outdated
| }, | ||
| "scripts": { | ||
| "test": [ | ||
| "check": [ | ||
| "@composer-validate", |
There was a problem hiding this comment.
This is also ran in ci/qa/validate , is this because it needs to get validated from both inside and outside composer.json ?
There was a problem hiding this comment.
👍 You found a bug here!
I now call the validate script which for now performs the same logic, but it could just as well do more than just validate the composer lockfile.
parijke
requested changes
Jan 22, 2024
Also optimized imports with it.
|
Thanks for the many good suggestions @parijke I did not fix all of them. Most of the dev/test related stuff is left as-is. As they add limited added value for now. If you disagree, feel free discuss. |
MKodde
force-pushed
the
feature/rejuvination
branch
from
db638c1 to
3944dcf
Compare
The form was not using the correct bootstrap form classes so was ugly
parijke
approved these changes
Feb 7, 2024
MKodde
merged commit 35ddce5
into
feature/build-and-publish-test-container
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks the end of an era. The code has been:
App/namespace. Tiqr now also adheres to the Vendor/Projectname convetion. And was baptized:Surfnet/TiqrOn other fronts: